Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiCard icon prop preserve className #684

Merged
merged 3 commits into from
Apr 17, 2018
Merged

EuiCard icon prop preserve className #684

merged 3 commits into from
Apr 17, 2018

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Apr 17, 2018 •
edited
Loading

EuiCard icon prop overrides user provided className with euiCard__icon. This PR fixes the logic to add euiCard__icon to any user provided classNames.

@nreese nreese requested a review from cchaos April 17, 2018 22:15
cchaos
cchaos approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM

@nreese nreese merged commit 1dde164 into elastic:master Apr 17, 2018
@nreese nreese mentioned this pull request Apr 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nreese @cchaos