at & key Icon Glyphs
#6934
Merged
at & key Icon Glyphs
#6934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 11, 2023 16:42
|
💚 CLA has been signed |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6934/ |
|
Not sure why I'm being flagged by the CLA checker. I signed it years ago when I joined Elastic, and I've resigned it multiple times this week to no avail. |
|
@MichaelMarcialis looks like you're passing now! Huzzah! @ryankeairns Did you want to review this at all, or are we good to merge? From a code standpoint it LGTM |
|
Looks good to me! |
ryankeairns
approved these changes
Jul 14, 2023
26 tasks
dej611
added a commit
to elastic/kibana
that referenced
this pull request
Jul 20, 2023
## Summary Fixes #160232 This PR removes completely FontAwesome from the Graph plugin and replace its usage with mostly EUI + few Maki icons. As for the Google icon, @MichaelMarcialis do you think we should just have a custom SVG icon within the Graph app? Here's a list of the replaced icons, but if I forgot anything let me know: * [x] Created generic `IconRenderer` component to abstract away the package type from the rendering * [x] Add logic for color switch based on background color * Replace icons in graph visualization * [x] Replace with EUI icons * [x] Replace with Maki icons * [x] Add `prevName` to recover old saved graph SO * [x] Fix selection preview icon * For the `at` and `key` icons it needs to wait for a new EUI release with elastic/eui#6934 * Replace drill down icons * [x] Replace with EUI icons * [x] Replace with Maki icons * [x] Find a substitute for Google icon * [x] Add `prevName` to recover old saved graph SO * App toolbars * [x] Replace app toolbar icons with EUI icons * [x] Changed blocked list icon from `ban` to `filterIgnore` * [x] Replace styling icon + color swatches * The EUI `dot` icon was too small, so switches to rect icons * [x] Replace merge icons on link selection * [x] Replace group/ungroup icons with `fold/unfold` * [x] Custom drilldowns * [x] Removed `LegacyIcon` * Replaced usage in various places New icons within field configuration + graph visualization <img width="1061" alt="Screenshot 2023-07-17 at 11 00 35" src="https://github.com/elastic/kibana/assets/924948/59f981e7-64b7-4ce5-b3ae-2582d46fc373"> <img width="302" alt="Screenshot 2023-07-17 at 15 13 04" src="https://github.com/elastic/kibana/assets/924948/fb8d0e63-e982-406f-bd8d-036d71d37442"> New toolbar with blocked icon changed <img width="202" alt="Screenshot 2023-07-17 at 15 13 40" src="https://github.com/elastic/kibana/assets/924948/241206c4-7d3b-4296-bd6b-c2df3f3eabe5"> <img width="220" alt="Screenshot 2023-07-17 at 15 13 35" src="https://github.com/elastic/kibana/assets/924948/5a648932-2f79-4c0e-a8d0-3ab165f68036"> <img width="272" alt="Screenshot 2023-07-17 at 12 41 12" src="https://github.com/elastic/kibana/assets/924948/e3778d20-3000-496e-881b-61e5f086ae52"> New group/ungroup icons <img width="168" alt="Screenshot 2023-07-17 at 12 41 25" src="https://github.com/elastic/kibana/assets/924948/ffc963e6-4fea-4cb5-b0ef-cf8a71a71d6a"> <img width="252" alt="Screenshot 2023-07-17 at 15 15 27" src="https://github.com/elastic/kibana/assets/924948/98b8b025-32fd-465e-9a66-40f4f866eb6e"> Selection with icons preview <img width="260" alt="Screenshot 2023-07-17 at 15 07 17" src="https://github.com/elastic/kibana/assets/924948/08dbda17-0c12-4fa4-8c92-77bbe90d7e14"> <img width="268" alt="Screenshot 2023-07-17 at 15 07 35" src="https://github.com/elastic/kibana/assets/924948/78987838-42d5-46bf-9e46-b12cc603fa4e"> Panel with color styling open <img width="266" alt="Screenshot 2023-07-17 at 15 07 44" src="https://github.com/elastic/kibana/assets/924948/f5866e29-cf22-4e62-a2ff-3ef901c0d564"> Custom drilldowns (note Google icon has been replaced with a magnifier icon) <img width="331" alt="Screenshot 2023-07-18 at 17 49 07" src="https://github.com/elastic/kibana/assets/924948/42e307d1-69b6-4e79-9e19-64c5efb7ee46"> <img width="381" alt="Screenshot 2023-07-18 at 17 51 44" src="https://github.com/elastic/kibana/assets/924948/bc70c506-4390-45c1-aff5-8e22a68d7130"> <img width="271" alt="Screenshot 2023-07-17 at 15 08 31" src="https://github.com/elastic/kibana/assets/924948/59fea7e4-a775-4006-805d-0610d7861890"> <img width="269" alt="Screenshot 2023-07-17 at 15 08 38" src="https://github.com/elastic/kibana/assets/924948/f6c247a0-921d-4d9c-881a-796e02488df5"> Link selection <img width="295" alt="Screenshot 2023-07-17 at 15 09 06" src="https://github.com/elastic/kibana/assets/924948/d6a73013-130e-45a8-bdfc-48ac20e66a85"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Michael Marcialis <michael.l.marcialis@gmail.com>
Ikuni17
pushed a commit
to elastic/kibana
that referenced
this pull request
Jul 27, 2023
## Summary `eui@84.0.0` ⏩ `eui@85.0.1` ## [`85.0.1`](https://github.com/elastic/eui/tree/v85.0.1) **Bug fixes** - Fixed `EuiFilterGroup`'s responsive styles ([#6983](elastic/eui#6983)) ## [`85.0.0`](https://github.com/elastic/eui/tree/v85.0.0) - Updated `EuiThemeProvider` to set an Emotion theme context that returns the values of `useEuiTheme()` ([#6913](elastic/eui#6913)) - Added `size` prop to `EuiStepsHorizontal`, defaulting to the previous size of `m` ([#6928](elastic/eui#6928)) - Added new `s` sizing to `EuiStepsHorizontal` ([#6928](elastic/eui#6928)) - Added `at` and `key` icon glyphs. ([#6934](elastic/eui#6934)) - Added a new `cloneElementWithCss` Emotion utility ([#6939](elastic/eui#6939)) - Updated `EuiPopover` to allow consumer control of all `focusTrapProps` ([#6955](elastic/eui#6955)) **Bug fixes** - Fixed `EuiDataGrid` height calculation bug when browser zoom levels are not 100% ([#6895](elastic/eui#6895)) - Fixed `EuiTab` not correctly passing selection color state to `prepend` and `append` children ([#6938](elastic/eui#6938)) - Fixed `EuiInputPopover` to allow consumer control of its focus trap via `focusTrapProps` ([#6955](elastic/eui#6955)) **Breaking changes** - `EuiProvider` will no longer render multiple or duplicate nested instances of itself. If a nested `EuiProvider` is detected, that instance will return early without further processing, and will warn if configured to do so via `setEuiDevProviderWarning`. For nested theming, use `EuiThemeProvider` instead. ([#6949](elastic/eui#6949)) - Removed `onTrapDeactivation` prop from `EuiPopover`. Use `focusTrapProps.onDeactivation` instead ([#6955](elastic/eui#6955)) **CSS-in-JS conversions** - Converted `EuiFilterGroup` and `EuiFilterButton` to Emotion; Removed styles attached to `.euiFilterGroup__popoverPanel` ([#6957](elastic/eui#6957)) --------- Co-authored-by: Cee Chen <constance.chen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
## Summary Fixes elastic#160232 This PR removes completely FontAwesome from the Graph plugin and replace its usage with mostly EUI + few Maki icons. As for the Google icon, @MichaelMarcialis do you think we should just have a custom SVG icon within the Graph app? Here's a list of the replaced icons, but if I forgot anything let me know: * [x] Created generic `IconRenderer` component to abstract away the package type from the rendering * [x] Add logic for color switch based on background color * Replace icons in graph visualization * [x] Replace with EUI icons * [x] Replace with Maki icons * [x] Add `prevName` to recover old saved graph SO * [x] Fix selection preview icon * For the `at` and `key` icons it needs to wait for a new EUI release with elastic/eui#6934 * Replace drill down icons * [x] Replace with EUI icons * [x] Replace with Maki icons * [x] Find a substitute for Google icon * [x] Add `prevName` to recover old saved graph SO * App toolbars * [x] Replace app toolbar icons with EUI icons * [x] Changed blocked list icon from `ban` to `filterIgnore` * [x] Replace styling icon + color swatches * The EUI `dot` icon was too small, so switches to rect icons * [x] Replace merge icons on link selection * [x] Replace group/ungroup icons with `fold/unfold` * [x] Custom drilldowns * [x] Removed `LegacyIcon` * Replaced usage in various places New icons within field configuration + graph visualization <img width="1061" alt="Screenshot 2023-07-17 at 11 00 35" src="https://github.com/elastic/kibana/assets/924948/59f981e7-64b7-4ce5-b3ae-2582d46fc373"> <img width="302" alt="Screenshot 2023-07-17 at 15 13 04" src="https://github.com/elastic/kibana/assets/924948/fb8d0e63-e982-406f-bd8d-036d71d37442"> New toolbar with blocked icon changed <img width="202" alt="Screenshot 2023-07-17 at 15 13 40" src="https://github.com/elastic/kibana/assets/924948/241206c4-7d3b-4296-bd6b-c2df3f3eabe5"> <img width="220" alt="Screenshot 2023-07-17 at 15 13 35" src="https://github.com/elastic/kibana/assets/924948/5a648932-2f79-4c0e-a8d0-3ab165f68036"> <img width="272" alt="Screenshot 2023-07-17 at 12 41 12" src="https://github.com/elastic/kibana/assets/924948/e3778d20-3000-496e-881b-61e5f086ae52"> New group/ungroup icons <img width="168" alt="Screenshot 2023-07-17 at 12 41 25" src="https://github.com/elastic/kibana/assets/924948/ffc963e6-4fea-4cb5-b0ef-cf8a71a71d6a"> <img width="252" alt="Screenshot 2023-07-17 at 15 15 27" src="https://github.com/elastic/kibana/assets/924948/98b8b025-32fd-465e-9a66-40f4f866eb6e"> Selection with icons preview <img width="260" alt="Screenshot 2023-07-17 at 15 07 17" src="https://github.com/elastic/kibana/assets/924948/08dbda17-0c12-4fa4-8c92-77bbe90d7e14"> <img width="268" alt="Screenshot 2023-07-17 at 15 07 35" src="https://github.com/elastic/kibana/assets/924948/78987838-42d5-46bf-9e46-b12cc603fa4e"> Panel with color styling open <img width="266" alt="Screenshot 2023-07-17 at 15 07 44" src="https://github.com/elastic/kibana/assets/924948/f5866e29-cf22-4e62-a2ff-3ef901c0d564"> Custom drilldowns (note Google icon has been replaced with a magnifier icon) <img width="331" alt="Screenshot 2023-07-18 at 17 49 07" src="https://github.com/elastic/kibana/assets/924948/42e307d1-69b6-4e79-9e19-64c5efb7ee46"> <img width="381" alt="Screenshot 2023-07-18 at 17 51 44" src="https://github.com/elastic/kibana/assets/924948/bc70c506-4390-45c1-aff5-8e22a68d7130"> <img width="271" alt="Screenshot 2023-07-17 at 15 08 31" src="https://github.com/elastic/kibana/assets/924948/59fea7e4-a775-4006-805d-0610d7861890"> <img width="269" alt="Screenshot 2023-07-17 at 15 08 38" src="https://github.com/elastic/kibana/assets/924948/f6c247a0-921d-4d9c-881a-796e02488df5"> Link selection <img width="295" alt="Screenshot 2023-07-17 at 15 09 06" src="https://github.com/elastic/kibana/assets/924948/d6a73013-130e-45a8-bdfc-48ac20e66a85"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Michael Marcialis <michael.l.marcialis@gmail.com>
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
## Summary `eui@84.0.0` ⏩ `eui@85.0.1` ## [`85.0.1`](https://github.com/elastic/eui/tree/v85.0.1) **Bug fixes** - Fixed `EuiFilterGroup`'s responsive styles ([elastic#6983](elastic/eui#6983)) ## [`85.0.0`](https://github.com/elastic/eui/tree/v85.0.0) - Updated `EuiThemeProvider` to set an Emotion theme context that returns the values of `useEuiTheme()` ([elastic#6913](elastic/eui#6913)) - Added `size` prop to `EuiStepsHorizontal`, defaulting to the previous size of `m` ([elastic#6928](elastic/eui#6928)) - Added new `s` sizing to `EuiStepsHorizontal` ([elastic#6928](elastic/eui#6928)) - Added `at` and `key` icon glyphs. ([elastic#6934](elastic/eui#6934)) - Added a new `cloneElementWithCss` Emotion utility ([elastic#6939](elastic/eui#6939)) - Updated `EuiPopover` to allow consumer control of all `focusTrapProps` ([elastic#6955](elastic/eui#6955)) **Bug fixes** - Fixed `EuiDataGrid` height calculation bug when browser zoom levels are not 100% ([elastic#6895](elastic/eui#6895)) - Fixed `EuiTab` not correctly passing selection color state to `prepend` and `append` children ([elastic#6938](elastic/eui#6938)) - Fixed `EuiInputPopover` to allow consumer control of its focus trap via `focusTrapProps` ([elastic#6955](elastic/eui#6955)) **Breaking changes** - `EuiProvider` will no longer render multiple or duplicate nested instances of itself. If a nested `EuiProvider` is detected, that instance will return early without further processing, and will warn if configured to do so via `setEuiDevProviderWarning`. For nested theming, use `EuiThemeProvider` instead. ([elastic#6949](elastic/eui#6949)) - Removed `onTrapDeactivation` prop from `EuiPopover`. Use `focusTrapProps.onDeactivation` instead ([elastic#6955](elastic/eui#6955)) **CSS-in-JS conversions** - Converted `EuiFilterGroup` and `EuiFilterButton` to Emotion; Removed styles attached to `.euiFilterGroup__popoverPanel` ([elastic#6957](elastic/eui#6957)) --------- Co-authored-by: Cee Chen <constance.chen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've added new
atandkeyicon glyphs as part of the effort to remove FontAwesome from the Graph app.Note that while we do have existing icon tokens for these, the weight and stylistic differences in the token versions causes them to clash visually when in close proximity to our regular icon glyphs. That said, I opted to not reuse the same SVGs from the token versions and instead created unique glyph versions for these icons.
CCing @dej611, as this is related to #6918.
QA
Remove or strikethrough items that do not apply to your PR.
General checklist