Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report unhandled Promise rejections #6939

Merged
merged 1 commit into from
Apr 25, 2016
Merged

Report unhandled Promise rejections #6939

merged 1 commit into from
Apr 25, 2016

Conversation

bevacqua
Copy link
Contributor

No description provided.

@rashidkpc
Copy link
Contributor

Can you give examples of where this is currently happening? I don't want to intentionally throw unactionable notifications at users.

@bevacqua
Copy link
Contributor Author

  • It's a debugging feature
  • It won't, it prints to the console

@rashidkpc
Copy link
Contributor

Ah, I missed the notify.log() 👍

@epixa
Copy link
Contributor

epixa commented Apr 15, 2016

What's a good way to test this? For the server, I tried manually creating rejected promises and it hasn't logged anything even if I add a success handler to the promise that gets rejected.

@epixa
Copy link
Contributor

epixa commented Apr 15, 2016

Ah ha, I got it. This only works on bluebird promises. Native promises in node don't fire the event.

@epixa
Copy link
Contributor

epixa commented Apr 15, 2016

I was able to get this to work when using non-native promises on node, but I can't get this logging to work at all on the client-side. It isn't firing for native promises or our custom angular promise service thing. When specifically should this work on the client?

@epixa epixa assigned bevacqua and unassigned epixa Apr 15, 2016
@bevacqua
Copy link
Contributor Author

This is working just fine for me on the client-side as well. If you run the following command in your console you should see the logged message in supporting browsers (it doesn't affect unsupported browsers at all)

screen shot 2016-04-18 at 19 28 12

@bevacqua bevacqua assigned epixa and unassigned bevacqua Apr 18, 2016
@epixa
Copy link
Contributor

epixa commented Apr 19, 2016

LGTM

@epixa epixa assigned bevacqua and unassigned epixa Apr 19, 2016
@bevacqua bevacqua assigned tsullivan and rashidkpc and unassigned bevacqua and tsullivan Apr 19, 2016
@bevacqua
Copy link
Contributor Author

@rashidkpc Could I get your pretty eyes on this?

@rashidkpc rashidkpc merged commit b0305ea into elastic:master Apr 25, 2016
Ikuni17 pushed a commit that referenced this pull request Jul 27, 2023
@tkajtoch @cee-chen @kibanamachine
Upgrade @elastic/eui to 85.0.1 (#162209)
1c42ee9 
## Summary

`eui@84.0.0` ⏩ `eui@85.0.1`

## [`85.0.1`](https://github.com/elastic/eui/tree/v85.0.1)

**Bug fixes**

- Fixed `EuiFilterGroup`'s responsive styles
([#6983](elastic/eui#6983))

## [`85.0.0`](https://github.com/elastic/eui/tree/v85.0.0)

- Updated `EuiThemeProvider` to set an Emotion theme context that
returns the values of `useEuiTheme()`
([#6913](elastic/eui#6913))
- Added `size` prop to `EuiStepsHorizontal`, defaulting to the previous
size of `m` ([#6928](elastic/eui#6928))
- Added new `s` sizing to `EuiStepsHorizontal`
([#6928](elastic/eui#6928))
- Added `at` and `key` icon glyphs.
([#6934](elastic/eui#6934))
- Added a new `cloneElementWithCss` Emotion utility
([#6939](elastic/eui#6939))
- Updated `EuiPopover` to allow consumer control of all `focusTrapProps`
([#6955](elastic/eui#6955))

**Bug fixes**

- Fixed `EuiDataGrid` height calculation bug when browser zoom levels
are not 100% ([#6895](elastic/eui#6895))
- Fixed `EuiTab` not correctly passing selection color state to
`prepend` and `append` children
([#6938](elastic/eui#6938))
- Fixed `EuiInputPopover` to allow consumer control of its focus trap
via `focusTrapProps` ([#6955](elastic/eui#6955))

**Breaking changes**

- `EuiProvider` will no longer render multiple or duplicate nested
instances of itself. If a nested `EuiProvider` is detected, that
instance will return early without further processing, and will warn if
configured to do so via `setEuiDevProviderWarning`. For nested theming,
use `EuiThemeProvider` instead.
([#6949](elastic/eui#6949))
- Removed `onTrapDeactivation` prop from `EuiPopover`. Use
`focusTrapProps.onDeactivation` instead
([#6955](elastic/eui#6955))

**CSS-in-JS conversions**

- Converted `EuiFilterGroup` and `EuiFilterButton` to Emotion; Removed
styles attached to `.euiFilterGroup__popoverPanel`
([#6957](elastic/eui#6957))

---------

Co-authored-by: Cee Chen <constance.chen@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
@tkajtoch @cee-chen @kibanamachine
Upgrade @elastic/eui to 85.0.1 (elastic#162209)
5f2e2ba 
## Summary

`eui@84.0.0` ⏩ `eui@85.0.1`

## [`85.0.1`](https://github.com/elastic/eui/tree/v85.0.1)

**Bug fixes**

- Fixed `EuiFilterGroup`'s responsive styles
([elastic#6983](elastic/eui#6983))

## [`85.0.0`](https://github.com/elastic/eui/tree/v85.0.0)

- Updated `EuiThemeProvider` to set an Emotion theme context that
returns the values of `useEuiTheme()`
([elastic#6913](elastic/eui#6913))
- Added `size` prop to `EuiStepsHorizontal`, defaulting to the previous
size of `m` ([elastic#6928](elastic/eui#6928))
- Added new `s` sizing to `EuiStepsHorizontal`
([elastic#6928](elastic/eui#6928))
- Added `at` and `key` icon glyphs.
([elastic#6934](elastic/eui#6934))
- Added a new `cloneElementWithCss` Emotion utility
([elastic#6939](elastic/eui#6939))
- Updated `EuiPopover` to allow consumer control of all `focusTrapProps`
([elastic#6955](elastic/eui#6955))

**Bug fixes**

- Fixed `EuiDataGrid` height calculation bug when browser zoom levels
are not 100% ([elastic#6895](elastic/eui#6895))
- Fixed `EuiTab` not correctly passing selection color state to
`prepend` and `append` children
([elastic#6938](elastic/eui#6938))
- Fixed `EuiInputPopover` to allow consumer control of its focus trap
via `focusTrapProps` ([elastic#6955](elastic/eui#6955))

**Breaking changes**

- `EuiProvider` will no longer render multiple or duplicate nested
instances of itself. If a nested `EuiProvider` is detected, that
instance will return early without further processing, and will warn if
configured to do so via `setEuiDevProviderWarning`. For nested theming,
use `EuiThemeProvider` instead.
([elastic#6949](elastic/eui#6949))
- Removed `onTrapDeactivation` prop from `EuiPopover`. Use
`focusTrapProps.onDeactivation` instead
([elastic#6955](elastic/eui#6955))

**CSS-in-JS conversions**

- Converted `EuiFilterGroup` and `EuiFilterButton` to Emotion; Removed
styles attached to `.euiFilterGroup__popoverPanel`
([elastic#6957](elastic/eui#6957))

---------

Co-authored-by: Cee Chen <constance.chen@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review v5.0.0-alpha2 v5.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bevacqua @rashidkpc @epixa @tsullivan