Updated react-vis to 1.10.2 #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerprall
suggested changes
Jul 11, 2018
CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| ## [`master`](https://github.com/elastic/eui/tree/master) | |||
|
|
|||
| No public interface changes since `1.2.1`. | |||
| - No public interface changes since `1.2.1`. | |||
There was a problem hiding this comment.
remove the no changes line
| aria-label="aria-label" | ||
| class="testClass1 testClass2" | ||
| data-test-subj="test subject string" | ||
| class="rv-xy-plot " |
There was a problem hiding this comment.
removing the wrapping div takes away support for aria-label, class, data-test-subj, and other custom attributes
|
@markov00 Sorry, I'm slammed so I'm going to have to remove myself from the review. |
|
@chandlerprall I've updated the PR following your requested changes. |
The features we introduced in XYPlot are now merged into react-vis after uber/react-vis#857. The XYPlotExtended class is removed. The div aroung the XYPlot is also removed since it's not required. All snapshots are updated after this removal.
Check this issue comments to see the status: uber/react-vis#861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
react-vislib to1.10.2and sticked to that version (see my comment on this uber/react-vis#861) that's includes our PR uber/react-vis#857 to align XYPlot events handlers introducing some more event handlers we are using on EuiXYChart.This PR get rid of the introduced XYPlotExtended class used to include these handlers before the PR merge.
The package version in
package.jsonis also updated since the PR was merged and available only from1.10.2version.The div around the XYPlot was also removed since it is not required anymore. All snapshots are updated after this removal.