Align onParentEventType callbacks across XYPlot #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mouse handlers in XYPlot receive SyntheticEvents and not Native Events
by defaults.
Aligned all callback to be called with event parameters, and not with
an object like { event: event }
Align the mouseEnter and mouseLeave handler to call respective onParentEventType callback for every series child
|
|
mcnuttandrew
approved these changes
Jul 10, 2018
markov00
added a commit
to elastic/eui
that referenced
this pull request
Jul 13, 2018
* Updated react-vis to 1.10.2 The features we introduced in XYPlot are now merged into react-vis after uber/react-vis#857. The XYPlotExtended class is removed. The div aroung the XYPlot is also removed since it's not required. All snapshots are updated after this removal. * Updated CHANGELOG * Reverting 492d28a to keep the wrapping div around the chart * Fixed the react-vis version to the stable one. Check this issue comments to see the status: uber/react-vis#861
ayarcohaila
pushed a commit
to ayarcohaila/react-vis
that referenced
this pull request
Jun 30, 2021
* Aligned mouse handlers docs and callback format
Mouse handlers in XYPlot receive SyntheticEvents and not Native Events
by defaults.
Aligned all callback to be called with event parameters, and not with
an object like { event: event }
* Add onParentMouseEnter and onParentMouseLeave
Align the mouseEnter and mouseLeave handler to call respective
onParentEventType callback for every series child
* Add onMouseUp calls and handlers
* Updated docs for onMouseUp prop
* Fix wrong callback for onTouchStart
* Add tests for onParentEventType handlers
ayarcohaila
added a commit
to ayarcohaila/react-vis
that referenced
this pull request
May 30, 2023
* Aligned mouse handlers docs and callback format
Mouse handlers in XYPlot receive SyntheticEvents and not Native Events
by defaults.
Aligned all callback to be called with event parameters, and not with
an object like { event: event }
* Add onParentMouseEnter and onParentMouseLeave
Align the mouseEnter and mouseLeave handler to call respective
onParentEventType callback for every series child
* Add onMouseUp calls and handlers
* Updated docs for onMouseUp prop
* Fix wrong callback for onTouchStart
* Add tests for onParentEventType handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrate and fix the following:
{event: event}. I've aligned all the callbacksonParentMouseLeaveandonParentMouseEntercallbacks for series components. Although this is not directly used by components inreact-visI think there are cases where a developer wants to extend anAbstractSeriesand needs theonParentMouseUpor onParentMouseLeave events. We are for example on creating our own Crosshair but extending anAbstractSeriesso we have the access to all the plot data as props in side the component. HavingonParentMouseLeavehelps us to hide the crosshair.onMouseUpprop to XYPlot and relativeonParentMouseUphandleronTouchStarthandler (wasonMouseDown)