Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Abort image building process if the npcap file non found #384

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Jan 25, 2024

1.79 release caused a problem: the npcap-1.79.exe was missing and broken images were published despite of that.
Now it will stop building process if the required file is missing.

@pazone pazone requested review from v1v, andrewkroh and oakrizan January 25, 2024 15:18
Copy link

mergify bot commented Jan 25, 2024

This pull request does not have a backport label. Could you fix it @pazone? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d is the label to automatically backport to the 1./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

andrewkroh
andrewkroh previously approved these changes Jan 25, 2024
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think there is also value in #383 which will fail the docker build if the file is not present.

v1v
v1v previously approved these changes Jan 25, 2024
@pazone pazone dismissed stale reviews from v1v and andrewkroh via 177790e January 25, 2024 15:36
@elasticmachine
Copy link

💚 Build Succeeded

History

@elasticmachine
Copy link

💚 Build Succeeded

History

@pazone pazone enabled auto-merge (squash) January 25, 2024 16:33
@elasticmachine
Copy link

💚 Build Succeeded

History

@pazone pazone merged commit afadbf3 into main Jan 25, 2024
10 checks passed
@pazone pazone deleted the ci_fail_if_no_npcap branch January 25, 2024 16:48
@v1v
Copy link
Member

v1v commented Jan 25, 2024

@pazone , this PR should be backported, too; I added the required label.

All the changes in golang-crossbuild@main should be backported to the branch matching the support Golang versions by default. There might be cases that are not required... but the golden-rule is backport it

Golang supports two versions, that's the same principle for this particular repository.

In other words, as of today, Golang supports 1.21 and 1.20, and that's the same in this repository, with the difference that main is using 1.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants