-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Abort image building process if the npcap file non found #384
Conversation
This pull request does not have a backport label. Could you fix it @pazone? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think there is also value in #383 which will fail the docker build
if the file is not present.
💚 Build Succeeded
History
|
💚 Build Succeeded
History
|
💚 Build Succeeded
History
|
@pazone , this PR should be backported, too; I added the required label. All the changes in Golang supports two versions, that's the same principle for this particular repository. In other words, as of today, Golang supports |
1.79
release caused a problem: thenpcap-1.79.exe
was missing and broken images were published despite of that.Now it will stop building process if the required file is missing.