Adding generic_logs template for hints autodiscovery #304
Conversation
...-management/elastic-agent/configuration/autodiscovery/kubernetes-hints-autodiscover.asciidoc
Outdated
Show resolved
Hide resolved
...-management/elastic-agent/configuration/autodiscovery/kubernetes-hints-autodiscover.asciidoc
Outdated
Show resolved
Hide resolved
| [discrete] | ||
| === Hints autodiscovery for kubernetes log collection | ||
|
|
||
| The log collection for Kubernetes autodiscovered pods can be supported by using https://github.com/elastic/elastic-agent/tree/main/deploy/kubernetes/elastic-agent-standalone/templates.d/container_logs.yml[container_logs.yml template]. Users need to emit a caontainer_logs mapping so as to start collecting logs for all the discovered containers *even if no annotations are present in the containers*. |
There was a problem hiding this comment.
Users do not emit any mappings right? This sentence does not look correct.
| enabled: true | ||
| ---- | ||
|
|
||
| Example to manually mount the needed container_logs template under the inputs.d folder of Elastic Agent |
There was a problem hiding this comment.
Why we need this extra mount? All templates are mounted automatically under /etc/elastic-agent/inputs.d if we uncomment the respective parts in the k8s manifests. So I see no need to specifically mount this one.
There was a problem hiding this comment.
Well yes. I wanted to give an example of manual mount in order to make clear that the initcontainer is not needed.
Do you think shall I be more specific here? This is something that came out from the call form BY
So wanted to also provided such an example
What do you think? Shall I completely remove it?
There was a problem hiding this comment.
I think that if we want an example with custom template's addition we should create a separate section for this and be specific there.
There was a problem hiding this comment.
Ok removed mount info and updated the section a bit
…overy/kubernetes-hints-autodiscover.asciidoc Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
…overy/kubernetes-hints-autodiscover.asciidoc Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
|
Also shall we completely remove the respective part from the plain policy of standalone manifests? Like in https://github.com/elastic/elastic-agent/blob/8d538f7befb4859d7cd0aef68658010d2ac5e1c6/deploy/kubernetes/elastic-agent-kustomize/default/elastic-agent-standalone/base/elastic-agent-standalone-daemonset-configmap.yaml#L362-L383? |
|
@ChrsMark nice idea: I have removed them in relevant PR: https://github.com/elastic/elastic-agent/pull/2986/files |
Adding Documentation for generic_logs template for Elastic Agent Hints Autodiscovery scenario in order to collect logs from k8s pods