adding docs for default container in 8.9

[gizas]

PR to manually backport changes that were merged into main with the following original PR:

• Adding generic_logs template for hints autodiscovery #304

• and Default container documentation backport #380

• Closes Document default_container_logs setting of k8s provider elastic-agent#3158

[ChrsMark]

@gizas I cannot follow which PRs should be back-ported and how all these are related. Can you make it more clear in the description? We will need this as future reference as well.

For example how is this one related with #384 and why we have this warning message at #380 (comment)?

[ChrsMark]

Also please add the original PR that this one backports.

#380 that is mentioned in the description changes only 2 lines but this one 119. How is this possible? Do we miss sth here?

[ChrsMark]

Let's clarify #386 (comment) before merging.

[gizas]

Initial PR that was merged to master was #304

This one needs to be backported to 8.9.

The warning comes from the automated backport of 2baca48 which failed

[ChrsMark]

Why #380 is mentioned in the description then? If that's wrong can you please fix it?

[gizas]

Why #380 is mentioned in the description then? If that's wrong can you please fix it?

It is not wrong, the above PR might have been merged (as main included forward changes than 8.9) but the automatic backport failed.

That is why I have added the link to indicate that the manual backport is needed

[ChrsMark]

Well #380 is not a backport, it's against main, right?

Could you update the description of this current PR to clearly mention why it is related to any other PRs? The See relevant backport that failed #3801 is quite confusing since without context makes me think that for some reason is related to this one somehow.

[gizas]

Ok I updated the description.

FYI the #380 is against main but it had the label backport-8.9, so this would trigger the backport. This is probably what it was not clearly from the beginning.

I have closed the duplicate #386

[ChrsMark]

Thanks!

FYI an PR against main cannot be called a "backport" no matter what labels it has. PRs against main are considered as original PRs and then all their "mirrored" PRs against specific tags/version-branches are their backports. That's the semantic that we have been following.

[ChrsMark]

That section does not exist in https://github.com/elastic/ingest-docs/pull/304/files. Is this coming from another PR? If so we should mention it as well in the description.

[gizas]

Updated the desc, it was the #380

[kilfoyle]

LGTM! 🚀
Thanks for tidying up the description @gizas

[ChrsMark]

LGTM

[ChrsMark]

Just a note that container_logs package only made it to main with elastic/elastic-agent#2981 but it doesn't make sense to restrict it since we always pull the templates from latest main: https://github.com/elastic/elastic-agent/blob/083bf7805afc9d57727b099da6fa48cf96719585/deploy/kubernetes/elastic-agent-standalone-kubernetes.yaml#L686