Rename logs to logfile #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
|
ruflin
approved these changes
Jul 2, 2020
|
29 tasks
|
@ph @michalpristas As a follow up, we must also adjust it in the storage so we then can remove it in the agent itself. Tracking the progress also here: elastic/package-registry#517 @jonathan-buttner I doubt this affects you. |
Thanks for the ping, yeah I don't think it will 👍 |
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
* Rename logs to logfile * Rename input.type in config_templates * Adjust config_template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is another trial of renaming logs to logfile for stream.inputs only.
I didn't update the dependency on the package-registry, as there are breaking changes (ProductRequirement is missing).
How to test this PR locally
To verify what does the new integration look like:
Related issues