Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constraints instead of requirements #149

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Use constraints instead of requirements #149

merged 2 commits into from
Jul 2, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Jul 2, 2020

What does this PR do?

Kibana stopped working due to elastic/kibana#70572. Probably it's an issue with missing contraints.

@mtojek mtojek added the bug Something isn't working, use only for issues label Jul 2, 2020
@mtojek mtojek self-assigned this Jul 2, 2020
@mtojek mtojek mentioned this pull request Jul 2, 2020
Merged
@mtojek mtojek marked this pull request as ready for review July 2, 2020 11:06
@mtojek mtojek added the Team:Integrations Label for the Integrations team label Jul 2, 2020
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

ruflin
ruflin approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I suggest in a follow up to update all packages to use ^7.9.0 as the requirement. As these packages will only be rolled out with 7.9.0 anyway.

@ruflin ruflin mentioned this pull request Jul 2, 2020
Closed
@mtojek mtojek merged commit 54028d5 into elastic:master Jul 2, 2020
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@mtojek
Use constraints instead of requirements (elastic#149)
edef0d2 
* Use constraints instead of requirements

* Fix: typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@mtojek mtojek

Labels
bug Something isn't working, use only for issues Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @elasticmachine @ruflin