elastic_agent - Set specific object_type_mapping_type #7179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
bug
4 tasks
Avoid wildcard value for `object_type_mapping_type` so that objects are not matched. The problem was that `filebeat_input.httpjson_interval_pages_total`, which holds an object, was being matched by the dynamic mapping specified for `filebeat_input.*_total`. This made it a long which led to a mapping exception. Fixes elastic/beats#35933
andrewkroh
force-pushed
the
elastic_agent/bugfix/fb-input-histogram-type-match
branch
from
21a0c91
to
3dee69a
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
chrisberkhout
approved these changes
Jul 28, 2023
andrewkroh
commented
Jul 28, 2023
|
Package elastic_agent - 1.9.1 containing this change is available at https://epr.elastic.co/search?package=elastic_agent |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoid wildcard value for
object_type_mapping_typeso that objects are not matched. The problem was thatfilebeat_input.httpjson_interval_pages_total, which holds an object, was being matched by the dynamic mapping specified forfilebeat_input.*_total.Fixes elastic/beats#35933
Checklist
changelog.ymlfile.Mappings
{ "dynamic": true, "dynamic_templates": [ { "container.labels": { "path_match": "container.labels.*", "mapping": { "type": "keyword" }, "match_mapping_type": "string" } }, { "filebeat_input.*.histogram.count": { "path_match": "filebeat_input.*.histogram.count", "mapping": { "type": "long" }, "match_mapping_type": "*" } }, { "filebeat_input.*.histogram.*": { "path_match": "filebeat_input.*.histogram.*", "mapping": { "type": "double" }, "match_mapping_type": "*" } }, { "filebeat_input.*_total": { "path_match": "filebeat_input.*_total", "mapping": { "type": "long" }, "match_mapping_type": "long" } }, { "filebeat_input.*_gauge": { "path_match": "filebeat_input.*_gauge", "mapping": { "type": "long" }, "match_mapping_type": "long" } }, { "filebeat_input.*_length": { "path_match": "filebeat_input.*_length", "mapping": { "type": "long" }, "match_mapping_type": "long" } } ], "properties": { "cloud": { "properties": { "availability_zone": { "ignore_above": 1024, "type": "keyword" }, "image": { "properties": { "id": { "ignore_above": 1024, "type": "keyword" } } }, "instance": { "properties": { "name": { "ignore_above": 1024, "type": "keyword" }, "id": { "ignore_above": 1024, "type": "keyword" } } }, "provider": { "ignore_above": 1024, "type": "keyword" }, "machine": { "properties": { "type": { "ignore_above": 1024, "type": "keyword" } } }, "project": { "properties": { "id": { "ignore_above": 1024, "type": "keyword" } } }, "region": { "ignore_above": 1024, "type": "keyword" }, "account": { "properties": { "id": { "ignore_above": 1024, "type": "keyword" } } } } }, "container": { "properties": { "image": { "properties": { "name": { "ignore_above": 1024, "type": "keyword" } } }, "name": { "ignore_above": 1024, "type": "keyword" }, "id": { "ignore_above": 1024, "type": "keyword" } } }, "agent": { "properties": { "build": { "properties": { "original": { "ignore_above": 1024, "type": "keyword" } } }, "name": { "ignore_above": 1024, "type": "keyword" }, "id": { "ignore_above": 1024, "type": "keyword" }, "ephemeral_id": { "ignore_above": 1024, "type": "keyword" }, "type": { "ignore_above": 1024, "type": "keyword" }, "version": { "ignore_above": 1024, "type": "keyword" } } }, "@timestamp": { "ignore_malformed": false, "type": "date" }, "ecs": { "properties": { "version": { "ignore_above": 1024, "type": "keyword" } } }, "log": { "properties": { "level": { "ignore_above": 1024, "type": "keyword" } } }, "data_stream": { "properties": { "namespace": { "type": "constant_keyword" }, "type": { "type": "constant_keyword" }, "dataset": { "type": "constant_keyword" } } }, "host": { "properties": { "hostname": { "ignore_above": 1024, "type": "keyword" }, "os": { "properties": { "build": { "ignore_above": 1024, "type": "keyword" }, "kernel": { "ignore_above": 1024, "type": "keyword" }, "codename": { "ignore_above": 1024, "type": "keyword" }, "name": { "ignore_above": 1024, "type": "keyword", "fields": { "text": { "type": "text" } } }, "family": { "ignore_above": 1024, "type": "keyword" }, "version": { "ignore_above": 1024, "type": "keyword" }, "platform": { "ignore_above": 1024, "type": "keyword" } } }, "domain": { "ignore_above": 1024, "type": "keyword" }, "ip": { "type": "ip" }, "containerized": { "type": "boolean" }, "name": { "ignore_above": 1024, "type": "keyword" }, "id": { "ignore_above": 1024, "type": "keyword" }, "type": { "ignore_above": 1024, "type": "keyword" }, "mac": { "ignore_above": 1024, "type": "keyword" }, "architecture": { "ignore_above": 1024, "type": "keyword" } } }, "filebeat_input": { "properties": { "input": { "ignore_above": 1024, "type": "keyword" }, "resource": { "ignore_above": 1024, "type": "keyword" }, "id": { "ignore_above": 1024, "type": "keyword" }, "bind_address": { "ignore_above": 1024, "type": "keyword" }, "device": { "ignore_above": 1024, "type": "keyword" }, "cel_executions": { "type": "long" }, "system_packet_drops": { "type": "long" } } } } }Screenshot
Proof that httpjson metrics can now be written to Elasticsearch.