Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mappings from filebeat_input_logs #7753

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Sep 11, 2023

What does this PR do?

When adding filebeat_input_metrics, another datastream filebeat_input_logs was automatically added by Fleet. More information can be found here - #5077 (comment).

The filebeat_input_metrics has undergone mapping changes such as #7179, thus making mappings undee filebeat_input_logs irrelevant. Since this datastream is only a placeholder and is always empty, this PR removes the mappings for it completely.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Note:

  • File packages/elastic_agent/data_stream/filebeat_input_logs/fields/base-fields.yml was not removed as package-spec requires atleast 1 file under fields folder. This file contains only base datastream fields data_stream.*

@kcreddy kcreddy added Integration:elastic_agent Elastic Agent enhancement New feature or request labels Sep 11, 2023
@kcreddy kcreddy marked this pull request as ready for review September 11, 2023 11:03
@kcreddy kcreddy requested a review from a team as a code owner September 11, 2023 11:03
@elasticmachine
Copy link

elasticmachine commented Sep 11, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-11T10:56:27.522+0000

  • Duration: 14 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.614
Classes 100.0% (0/0) 💚 2.614
Methods 33.333% (25/75) 👎 -59.235
Lines 100.0% (0/0) 💚 11.371
Conditionals 100.0% (0/0) 💚

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Sep 11, 2023
@elasticmachine
Copy link

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@kcreddy kcreddy merged commit bd73247 into elastic:main Sep 12, 2023
1 check passed
@elasticmachine
Copy link

Package elastic_agent - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=elastic_agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:elastic_agent Elastic Agent Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants