You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR replaces all .json pipeline test configuration files with equivalent *.yml ones. This ensures that all package-related configuration files are consistently in YAML format.
CI is failing on pipeline tests for the zoom integration. These failures are legitimate and will be resolved once elastic/elastic-package#264 is merged and the elastic-package dependency in this PR is updated.
@mtojek looks like the new static tests are failing for some packages in CI. Is this to be expected? I've rebased this PR on master and master CI is currently green. 🤔
@mtojek Actually I just updated the elastic-package dependency in this PR's go.mod again to point to a slightly older release (elastic/elastic-package@adf9302). That release does not include the static test runner changes, which are not needed for this PR anyway.
@mtojek Actually I just updated the elastic-package dependency in this PR's go.mod again to point to a slightly older release (elastic/elastic-package@adf9302). That release does not include the static test runner changes, which are not needed for this PR anyway.
Yes, that's why I pushed the static test runner, it's not really blocking :) Sorry for the confusion.
* Replacing .json pipeline test config files with .yml ones
* Removing header and trailing newline
* Removing leading whitespace columns
* Quoting @timestamp field
* Running elastic-package format on all packages
* Updating elastic-package dependency
* Updating elastic-package dependency
* Using older release of elastic-package
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ycombinator
force-pushed
the
pipeline-test-configs-yaml
branch
from
What does this PR do?
This PR replaces all
.jsonpipeline test configuration files with equivalent*.ymlones. This ensures that all package-related configuration files are consistently in YAML format.Related issues