-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should pipeline test config be in YAML? #106
Comments
I noticed this inconsistency and was wondering about it. +1 for using YAML for both. |
I'm going ahead with this change now. I've updated the issue description with a plan on how to roll out this change safely. Please review it. |
@ycombinator I think you can move forward with this issue. |
Thanks for the reminder, @mtojek. I'll move this forward today. |
All steps in the rollout plan (see issue description) are now done. Closing. |
* Update dependency on package-spec * Fix: make check
The system test configuration is expressed as YAML and many other package files are also expressed as YAML. However, pipeline test configuration files (example: https://github.com/elastic/package-spec/blob/master/code/go/internal/validator/test/packages/good/data_stream/foo/_dev/test/pipeline/test-access-raw.log-config.json) is expressed as JSON. Should we change this to be YAML as well?
Rollout plan for this change
*.yml
pipeline test configuration files in addition to the currently-allowed*.json
ones. Mark the*.json
file format as deprecated (exactly how to do this is TBD). This will give package authors some time to adjust their pipeline test configuration file formats: Deprecating JSON-formatted pipeline test configs in favor of YAML-formatted ones #139.integrations
repo from*.json
=>*.yml
: Replacing .json pipeline test config files with .yml ones integrations#739.*.json
pipeline test configuration files are being removed and replaced by*.yml
ones.*.json
pipeline test configuration files is being removed.*.json
pipeline test configuration files from package spec: Remove pipeline test config json #150.*.json
pipeline test configuration files has been removed.The text was updated successfully, but these errors were encountered: