Remove core->cli dependency (#95145)

* extract http_tools to package

* fix readme

* start moving stuff

* cleaning up `isDevCliParent`

* choose bootstrap script

* fix bootstrap script logic

* fix watch paths logic

* import REPO_ROOT from correct package

* create the @kbn/crypto package

* update core's `dev` config

* only export bootstrap function

* extract sslConfig to http-tools package

* fix core types

* fix optimizer tests

* fix cli_dev_mode tests

* fix basePath proxy tests

* update generated doc

* fix unit tests

* create @kbn/dev-cli-mode package

* remove useless comment

* self-review NITS

* update CODEOWNERS file

* add devOnly flag

* use variable for DEV_MODE_PATH

* review comments

* fix logger/log adapter

* fix log calls in base path proxy server

* address some review comments

* rename @kbn/http-tools to @kbn/server-http-tools

* more review comments

* move test to correct file

* add comment on getBootstrapScript

* fix lint

* lint

* add cli-dev-mode to eslint dev packages

* review comments

* update yarn.lock

* Revert "[ci] skip building ts refs when not necessary (#95739)"

This reverts commit e46a74f

.eslintrc.js

@@ -93,6 +93,7 @@ const SAFER_LODASH_SET_DEFINITELYTYPED_HEADER = `
 const DEV_PACKAGES = [
   'kbn-babel-code-parser',
   'kbn-dev-utils',
+  'kbn-cli-dev-mode',
   'kbn-docs-utils',
   'kbn-es*',
   'kbn-eslint*',

.github/CODEOWNERS

@@ -158,6 +158,7 @@
 /packages/kbn-ui-shared-deps/ @elastic/kibana-operations
 /packages/kbn-es-archiver/ @elastic/kibana-operations
 /packages/kbn-utils/ @elastic/kibana-operations
+/packages/kbn-cli-dev-mode/ @elastic/kibana-operations
 /src/cli/keystore/ @elastic/kibana-operations
 /src/legacy/server/warnings/ @elastic/kibana-operations
 /.ci/es-snapshots/ @elastic/kibana-operations
@@ -194,6 +195,8 @@
 /packages/kbn-config/ @elastic/kibana-core
 /packages/kbn-logging/ @elastic/kibana-core
 /packages/kbn-legacy-logging/ @elastic/kibana-core
+/packages/kbn-crypto/ @elastic/kibana-core
+/packages/kbn-http-tools/ @elastic/kibana-core
 /src/legacy/server/config/ @elastic/kibana-core
 /src/legacy/server/http/ @elastic/kibana-core
 /src/legacy/server/logging/ @elastic/kibana-core

docs/development/core/server/kibana-plugin-core-server.kibanaresponsefactory.md

@@ -10,10 +10,10 @@ Set of helpers used to create `KibanaResponse` to form HTTP response on an incom
 
 ```typescript
 kibanaResponseFactory: {
-    custom: <T extends string | Record<string, any> | Buffer | Error | Stream | {
+    custom: <T extends string | Record<string, any> | Error | Buffer | {
         message: string | Error;
         attributes?: Record<string, any> | undefined;
-    } | undefined>(options: CustomHttpResponseOptions<T>) => KibanaResponse<T>;
+    } | Stream | undefined>(options: CustomHttpResponseOptions<T>) => KibanaResponse<T>;
     badRequest: (options?: ErrorHttpResponseOptions) => KibanaResponse<ResponseError>;
     unauthorized: (options?: ErrorHttpResponseOptions) => KibanaResponse<ResponseError>;
     forbidden: (options?: ErrorHttpResponseOptions) => KibanaResponse<ResponseError>;

package.json

@@ -127,11 +127,13 @@
     "@kbn/apm-utils": "link:packages/kbn-apm-utils",
     "@kbn/config": "link:packages/kbn-config",
     "@kbn/config-schema": "link:packages/kbn-config-schema",
+    "@kbn/crypto": "link:packages/kbn-crypto",
     "@kbn/i18n": "link:packages/kbn-i18n",
     "@kbn/interpreter": "link:packages/kbn-interpreter",
     "@kbn/legacy-logging": "link:packages/kbn-legacy-logging",
     "@kbn/logging": "link:packages/kbn-logging",
     "@kbn/monaco": "link:packages/kbn-monaco",
+    "@kbn/server-http-tools": "link:packages/kbn-server-http-tools",
     "@kbn/std": "link:packages/kbn-std",
     "@kbn/tinymath": "link:packages/kbn-tinymath",
     "@kbn/ui-framework": "link:packages/kbn-ui-framework",
@@ -451,6 +453,7 @@
     "@jest/reporters": "^26.5.2",
     "@kbn/babel-code-parser": "link:packages/kbn-babel-code-parser",
     "@kbn/babel-preset": "link:packages/kbn-babel-preset",
+    "@kbn/cli-dev-mode": "link:packages/kbn-cli-dev-mode",
     "@kbn/dev-utils": "link:packages/kbn-dev-utils",
     "@kbn/docs-utils": "link:packages/kbn-docs-utils",
     "@kbn/es": "link:packages/kbn-es",

src/dev/cli_dev_mode/README.md → packages/kbn-cli-dev-mode/README.md

@@ -26,8 +26,12 @@ The `DevServer` object is responsible for everything related to running and rest
 
 The `Optimizer` object manages a `@kbn/optimizer` instance, adapting its configuration and logging to the data available to the CLI.
 
-## `BasePathProxyServer` (currently passed from core)
+## `BasePathProxyServer`
 
-The `BasePathProxyServer` is passed to the `CliDevMode` from core when the dev mode is trigged by the `--dev` flag. This proxy injects a random three character base path in the URL that Kibana is served from to help ensure that Kibana features are written to adapt to custom base path configurations from users.
+This proxy injects a random three character base path in the URL that Kibana is served from to help ensure that Kibana features 
+are written to adapt to custom base path configurations from users.
 
-The basePathProxy also has another important job, ensuring that requests don't fail because the server is restarting and that the browser receives front-end assets containing all saved changes. We accomplish this by observing the ready state of the `Optimizer` and `DevServer` objects and pausing all requests through the proxy until both objects report that they aren't building/restarting based on recently saved changes.
+The basePathProxy also has another important job, ensuring that requests don't fail because the server is restarting and 
+that the browser receives front-end assets containing all saved changes. We accomplish this by observing the ready state of 
+the `Optimizer` and `DevServer` objects and pausing all requests through the proxy until both objects report that 
+they aren't building/restarting based on recently saved changes.

packages/kbn-cli-dev-mode/jest.config.js

@@ -0,0 +1,13 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+module.exports = {
+  preset: '@kbn/test',
+  rootDir: '../..',
+  roots: ['<rootDir>/packages/kbn-cli-dev-mode'],
+};

packages/kbn-cli-dev-mode/package.json

@@ -0,0 +1,26 @@
+{
+  "name": "@kbn/cli-dev-mode",
+  "main": "./target/index.js",
+  "types": "./target/index.d.ts",
+  "version": "1.0.0",
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "private": true,
+  "scripts": {
+    "build": "../../node_modules/.bin/tsc",
+    "kbn:bootstrap": "yarn build",
+    "kbn:watch": "yarn build --watch"
+  },
+  "kibana": {
+    "devOnly": true
+  },
+  "dependencies": {
+    "@kbn/config": "link:../kbn-config",
+    "@kbn/config-schema": "link:../kbn-config-schema",
+    "@kbn/logging": "link:../kbn-logging",
+    "@kbn/server-http-tools": "link:../kbn-server-http-tools",
+    "@kbn/optimizer": "link:../kbn-optimizer",
+    "@kbn/std": "link:../kbn-std",
+    "@kbn/dev-utils": "link:../kbn-dev-utils",
+    "@kbn/utils": "link:../kbn-utils"
+  }
+}