Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] skip building ts refs when not necessary #95739

Merged
merged 2 commits into from
Mar 30, 2021
Merged

[ci] skip building ts refs when not necessary #95739

merged 2 commits into from
Mar 30, 2021

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Mar 30, 2021

We don't need to build TS refs in PRs, we can let TS do some extra work in the type_check step once the repo is setup rather than blocking all other tasks while we run this long task.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Mar 30, 2021
@spalger spalger requested a review from a team as a code owner March 30, 2021 02:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

mistic
mistic approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger enabled auto-merge (squash) March 30, 2021 02:34
@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 30, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit e46a74f into elastic:master Mar 30, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 30, 2021
@spalger @kibanamachine
[ci] skip building ts refs when not necessary (elastic#95739)
6d1f603 
Co-authored-by: spalger <spalger@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Mar 30, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #95740

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 30, 2021
@kibanamachine @spalger
[ci] skip building ts refs when not necessary (#95739) (#95740)
d79ef66 
Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Mar 30, 2021
@pgayvallet
Revert "[ci] skip building ts refs when not necessary (elastic#95739)"
b007289 
This reverts commit e46a74f
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Mar 30, 2021
@pgayvallet
Revert "[ci] skip building ts refs when not necessary (elastic#95739)"
3ba201f 
This reverts commit e46a74f
spalger pushed a commit that referenced this pull request Mar 30, 2021
@pgayvallet
Revert "[ci] skip building ts refs when not necessary (#95739)" (#95746)
cd703c0 
This reverts commit e46a74f
spalger added a commit to spalger/kibana that referenced this pull request Mar 30, 2021
@spalger
Revert "Revert "[ci] skip building ts refs when not necessary (elasti…
abd601e 
…c#95739)" (elastic#95746)"

This reverts commit cd703c0.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 30, 2021
@pgayvallet @kibanamachine
Revert "[ci] skip building ts refs when not necessary (elastic#95739)" (
ab84a93 
elastic#95746)

This reverts commit e46a74f
@kibanamachine kibanamachine mentioned this pull request Mar 30, 2021
Merged
@spalger spalger mentioned this pull request Mar 30, 2021
Merged
spalger pushed a commit that referenced this pull request Mar 30, 2021
@kibanamachine @pgayvallet
Revert "[ci] skip building ts refs when not necessary (#95739)" (#95746…
3d8702f 
…) (#95749)

This reverts commit e46a74f

Co-authored-by: Pierre Gayvallet <pierre.gayvallet@gmail.com>
mshustov pushed a commit to mshustov/kibana that referenced this pull request Mar 30, 2021
@spalger @mshustov
[ci] skip building ts refs when not necessary (elastic#95739)
b0b74cc 
Co-authored-by: spalger <spalger@users.noreply.github.com>
mshustov added a commit to mshustov/kibana that referenced this pull request Mar 30, 2021
@mshustov
Revert "[ci] skip building ts refs when not necessary (elastic#95739)"
ed68650 
This reverts commit b0b74cc.
pgayvallet added a commit that referenced this pull request Mar 30, 2021
@pgayvallet
Remove core->cli dependency (#95145)
265cc76 
* extract http_tools to package

* fix readme

* start moving stuff

* cleaning up `isDevCliParent`

* choose bootstrap script

* fix bootstrap script logic

* fix watch paths logic

* import REPO_ROOT from correct package

* create the @kbn/crypto package

* update core's `dev` config

* only export bootstrap function

* extract sslConfig to http-tools package

* fix core types

* fix optimizer tests

* fix cli_dev_mode tests

* fix basePath proxy tests

* update generated doc

* fix unit tests

* create @kbn/dev-cli-mode package

* remove useless comment

* self-review NITS

* update CODEOWNERS file

* add devOnly flag

* use variable for DEV_MODE_PATH

* review comments

* fix logger/log adapter

* fix log calls in base path proxy server

* address some review comments

* rename @kbn/http-tools to @kbn/server-http-tools

* more review comments

* move test to correct file

* add comment on getBootstrapScript

* fix lint

* lint

* add cli-dev-mode to eslint dev packages

* review comments

* update yarn.lock

* Revert "[ci] skip building ts refs when not necessary (#95739)"

This reverts commit e46a74f
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Mar 30, 2021
@pgayvallet
Remove core->cli dependency (elastic#95145)
aaa48d5 
* extract http_tools to package

* fix readme

* start moving stuff

* cleaning up `isDevCliParent`

* choose bootstrap script

* fix bootstrap script logic

* fix watch paths logic

* import REPO_ROOT from correct package

* create the @kbn/crypto package

* update core's `dev` config

* only export bootstrap function

* extract sslConfig to http-tools package

* fix core types

* fix optimizer tests

* fix cli_dev_mode tests

* fix basePath proxy tests

* update generated doc

* fix unit tests

* create @kbn/dev-cli-mode package

* remove useless comment

* self-review NITS

* update CODEOWNERS file

* add devOnly flag

* use variable for DEV_MODE_PATH

* review comments

* fix logger/log adapter

* fix log calls in base path proxy server

* address some review comments

* rename @kbn/http-tools to @kbn/server-http-tools

* more review comments

* move test to correct file

* add comment on getBootstrapScript

* fix lint

* lint

* add cli-dev-mode to eslint dev packages

* review comments

* update yarn.lock

* Revert "[ci] skip building ts refs when not necessary (elastic#95739)"

This reverts commit e46a74f
# Conflicts:
#	.github/CODEOWNERS
pgayvallet added a commit that referenced this pull request Mar 30, 2021
@pgayvallet
Remove core->cli dependency (#95145) (#95775)
41eb6e2 
* extract http_tools to package

* fix readme

* start moving stuff

* cleaning up `isDevCliParent`

* choose bootstrap script

* fix bootstrap script logic

* fix watch paths logic

* import REPO_ROOT from correct package

* create the @kbn/crypto package

* update core's `dev` config

* only export bootstrap function

* extract sslConfig to http-tools package

* fix core types

* fix optimizer tests

* fix cli_dev_mode tests

* fix basePath proxy tests

* update generated doc

* fix unit tests

* create @kbn/dev-cli-mode package

* remove useless comment

* self-review NITS

* update CODEOWNERS file

* add devOnly flag

* use variable for DEV_MODE_PATH

* review comments

* fix logger/log adapter

* fix log calls in base path proxy server

* address some review comments

* rename @kbn/http-tools to @kbn/server-http-tools

* more review comments

* move test to correct file

* add comment on getBootstrapScript

* fix lint

* lint

* add cli-dev-mode to eslint dev packages

* review comments

* update yarn.lock

* Revert "[ci] skip building ts refs when not necessary (#95739)"

This reverts commit e46a74f
# Conflicts:
#	.github/CODEOWNERS
spalger added a commit that referenced this pull request Apr 19, 2021
@spalger @kibanamachine
Revert "Revert "[ci] skip building ts refs when not necessary (#95739)…
b7a9b84 
…" (#95746)" (#95750)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Apr 19, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 19, 2021
@spalger @kibanamachine
Revert "Revert "[ci] skip building ts refs when not necessary (elasti…
c69d990 
…c#95739)" (elastic#95746)" (elastic#95750)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Apr 19, 2021
@kibanamachine @spalger
Revert "Revert "[ci] skip building ts refs when not necessary (#95739)…
0e42317 
…" (#95746)" (#95750) (#97493)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
madirey pushed a commit to madirey/kibana that referenced this pull request May 11, 2021
@spalger @kibanamachine @madirey
Revert "Revert "[ci] skip building ts refs when not necessary (elasti…
1542453 
…c#95739)" (elastic#95746)" (elastic#95750)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianseeders brianseeders brianseeders approved these changes

@mistic mistic mistic approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes reverted Team:Operations Team label for Operations Team v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spalger @elasticmachine @kibanamachine @brianseeders @mistic