Skip to content

Commit

Permalink
Unskip Serverless Observability Tests / serverless observability UI n…
Browse files Browse the repository at this point in the history
…avigation active sidenav section is auto opened on load (#162323)

## Summary

close #162781
Simulating flaky test run with for loop:
#162323 (comment)
  • Loading branch information
Dosant committed Aug 22, 2023
1 parent 79f8dcd commit 3458d7b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,17 @@ export function SvlCommonNavigationProvider(ctx: FtrProviderContext) {
},
async expectSectionOpen(sectionId: NavigationId) {
await this.expectSectionExists(sectionId);
const isOpen = await this.isSectionOpen(sectionId);
expect(isOpen).to.be(true);
await retry.waitFor(`section ${sectionId} to be open`, async () => {
const isOpen = await this.isSectionOpen(sectionId);
return isOpen;
});
},
async expectSectionClosed(sectionId: NavigationId) {
await this.expectSectionExists(sectionId);
const isOpen = await this.isSectionOpen(sectionId);
expect(isOpen).to.be(false);
await retry.waitFor(`section ${sectionId} to be closed`, async () => {
const isOpen = await this.isSectionOpen(sectionId);
return !isOpen;
});
},
async openSection(sectionId: NavigationId) {
await this.expectSectionExists(sectionId);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
await expectNoPageReload();
});

// FLAKY/BUG?: https://github.com/elastic/kibana/issues/162781
it.skip('active sidenav section is auto opened on load', async () => {
it('active sidenav section is auto opened on load', async () => {
await svlCommonNavigation.sidenav.openSection('project_settings_project_nav');
await svlCommonNavigation.sidenav.clickLink({ deepLinkId: 'management' });
await browser.refresh();
Expand Down

0 comments on commit 3458d7b

Please sign in to comment.