Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Serverless Observability Tests / serverless observability UI navigation active sidenav section is auto opened on load #162781

Closed
Dosant opened this issue Jul 31, 2023 · 3 comments · Fixed by #162323
Closed

Failing test: Serverless Observability Tests / serverless observability UI navigation active sidenav section is auto opened on load #162781

Dosant opened this issue Jul 31, 2023 · 3 comments · Fixed by #162323
Assignees
@Dosant
Labels
bug Fixes for quality problems that affect the customer experience failed-test A test failure on a tracked branch, potentially flaky-test Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) Project:Serverless Work as part of the Serverless project for its initial release Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@Dosant
Copy link
Contributor

Dosant commented Jul 31, 2023

Filing this manually, as serverless tests suites are not blocking yet:

#161341 (comment)

Failed CI Steps

Serverless Observability Tests
Test Failures

[job] [logs] Serverless Observability Tests / serverless observability UI navigation active sidenav section is auto opened on load

Note: flaky test runner for serverless test suite is not available yet: slack thread

Investigation:

cc @sebelga:

Test suite related to the side nav section auto-open logic is flaky, it might be that there is a legit bug/race condition with auto-open code

Looking at this screenshot we can see that the "Project settings" section didn't auto-open. We also can see that breadcrumb is in incorrect state. Likely the code didn't determine active path which would explain why both breadcrumbs and side nav are in incorrect state.

image
@Dosant Dosant added bug Fixes for quality problems that affect the customer experience failed-test A test failure on a tracked branch, potentially flaky-test Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Project:Serverless Work as part of the Serverless project for its initial release Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) labels Jul 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

Dosant added a commit to Dosant/kibana that referenced this issue Jul 31, 2023
@Dosant
skip elastic#162781
1edcf92
@Dosant Dosant mentioned this issue Jul 31, 2023
Merged
@sebelga
Copy link
Contributor

sebelga commented Jul 31, 2023

Looking at this screenshot we can see that the "Project settings" section didn't auto-open. We also can see that breadcrumb is in incorrect state. Likely the code didn't determine active path which would explain why both breadcrumbs and side nav are in incorrect state.

Can you reproduce the state locally? There is a delay between the rendering of the page and the active state that should be taken into account for the tests. But first let's see if this is an actual bug or just a flaky test.

Dosant added a commit that referenced this issue Jul 31, 2023
@Dosant
Skip Serverless Observability Tests / serverless observability UI nav…
41af3d6 
…igation active sidenav section is auto opened on load (#162782)

## Summary

skip #162781
@Dosant
Copy link
Contributor Author

Dosant commented Jul 31, 2023

Looking at this screenshot we can see that the "Project settings" section didn't auto-open. We also can see that breadcrumb is in incorrect state. Likely the code didn't determine active path which would explain why both breadcrumbs and side nav are in incorrect state.

Can you reproduce the state locally? There is a delay between the rendering of the page and the active state that should be taken into account for the tests. But first let's see if this is an actual bug or just a flaky test.

I tried a bit but couldn't repo locally.
Then I wanted to add a delay/retry to see if the state fixes itself eventually, but, for now, I can't validate it because flaky test runner is not available yet. So waiting for flaky test runner

@Dosant Dosant self-assigned this Jul 31, 2023
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@Dosant
Skip Serverless Observability Tests / serverless observability UI nav…
71b4e2e 
…igation active sidenav section is auto opened on load (elastic#162782)

## Summary

skip elastic#162781
@Dosant Dosant mentioned this issue Aug 21, 2023
Merged
Dosant added a commit that referenced this issue Aug 22, 2023
@Dosant
Unskip Serverless Observability Tests / serverless observability UI n…
3458d7b 
…avigation active sidenav section is auto opened on load (#162323)

## Summary

close #162781
Simulating flaky test run with for loop:
#162323 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dosant Dosant

Labels
bug Fixes for quality problems that affect the customer experience failed-test A test failure on a tracked branch, potentially flaky-test Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) Project:Serverless Work as part of the Serverless project for its initial release Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
3 participants
@sebelga @Dosant @elasticmachine