Skip to content

Commit

Permalink
[Security Solution][Detections] Removes ML Job Settings SIEM copy and…
Browse files Browse the repository at this point in the history
… fixes link to ML app for creating custom jobs (#76595)

## Summary

Resolves elastic/security-team#199

Removes remaining SIEM copy and fixes link to ML app for creating custom jobs

<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/92073438-e017d600-ed70-11ea-9827-7b5c9ffab7b1.gif" />
</p>



### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
  • Loading branch information
spong committed Sep 3, 2020
1 parent e2af848 commit 4140f2d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export const JobsTableComponent = ({ isLoading, jobs, onJobStateChange }: JobTab
columns={getJobsTableColumns(isLoading, onJobStateChange, basePath)}
items={getPaginatedItems(jobs, pageIndex, pageSize)}
loading={isLoading}
noItemsMessage={<NoItemsMessage />}
noItemsMessage={<NoItemsMessage basePath={basePath} />}
pagination={pagination}
responsive={false}
onChange={({ page }: { page: { index: number } }) => {
Expand All @@ -141,13 +141,13 @@ export const JobsTable = React.memo(JobsTableComponent);

JobsTable.displayName = 'JobsTable';

export const NoItemsMessage = React.memo(() => (
export const NoItemsMessage = React.memo(({ basePath }: { basePath: string }) => (
<EuiEmptyPrompt
title={<h3>{i18n.NO_ITEMS_TEXT}</h3>}
titleSize="xs"
actions={
<EuiButton
href="ml#/jobs/new_job/step/index_or_search"
href={`${basePath}/app/ml#/jobs/new_job/step/index_or_search`}
iconType="popout"
iconSide="right"
size="s"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const COLUMN_RUN_JOB = i18n.translate(
export const NO_ITEMS_TEXT = i18n.translate(
'xpack.securitySolution.components.mlPopup.jobsTable.noItemsDescription',
{
defaultMessage: 'No SIEM Machine Learning jobs found',
defaultMessage: 'No Security Machine Learning jobs found',
}
);

Expand Down

0 comments on commit 4140f2d

Please sign in to comment.