Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Removes ML Job Settings SIEM copy and fixes link to ML app for creating custom jobs #76595

Merged
merged 2 commits into from
Sep 3, 2020
Merged

[Security Solution][Detections] Removes ML Job Settings SIEM copy and fixes link to ML app for creating custom jobs #76595

merged 2 commits into from
Sep 3, 2020

Conversation

spong
Copy link
Member

@spong spong commented Sep 3, 2020

Summary

Resolves https://github.com/elastic/security-team/issues/199

Removes remaining SIEM copy and fixes link to ML app for creating custom jobs

Checklist

Delete any items that are not applicable to this PR.

@spong spong added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.2 labels Sep 3, 2020
@spong spong requested review from a team as code owners September 3, 2020 05:08
@spong spong self-assigned this Sep 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 9.8MB +77.0B 9.8MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dhurley14
dhurley14 approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@dhurley14 dhurley14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spong spong merged commit fb304b2 into elastic:master Sep 3, 2020
@spong spong deleted the ml-copy-and-url-fix branch September 3, 2020 22:16
This was referenced Sep 3, 2020
Merged
Merged
spong added a commit to spong/kibana that referenced this pull request Sep 3, 2020
@spong
[Security Solution][Detections] Removes ML Job Settings SIEM copy and…
4140f2d 
… fixes link to ML app for creating custom jobs (elastic#76595)

## Summary

Resolves elastic/security-team#199

Removes remaining SIEM copy and fixes link to ML app for creating custom jobs

<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/92073438-e017d600-ed70-11ea-9827-7b5c9ffab7b1.gif" />
</p>



### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
spong added a commit to spong/kibana that referenced this pull request Sep 3, 2020
@spong
[Security Solution][Detections] Removes ML Job Settings SIEM copy and…
d4228b3 
… fixes link to ML app for creating custom jobs (elastic#76595)

## Summary

Resolves elastic/security-team#199

Removes remaining SIEM copy and fixes link to ML app for creating custom jobs

<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/92073438-e017d600-ed70-11ea-9827-7b5c9ffab7b1.gif" />
</p>



### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 4, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-node/g…
8f365fa 
…rok/new-patterns-component-use-array

* 'master' of github.com:elastic/kibana: (75 commits)
  Remove legacy ui-apps-mixin (elastic#76604)
  remove unused test_utils (elastic#76528)
  [ML] Functional tests - add UI permission tests (elastic#76368)
  [APM] @ts-error -> @ts-expect-error (elastic#76492)
  [APM] Avoid negative offset for error marker on timeline (elastic#76638)
  [Reporting] rename interfaces to align with task manager integration (elastic#76716)
  Revert back ESO migration for alerting, added try/catch logic to avoid failing Kibana on start (elastic#76220)
  Test reverting "Add plugin status API (elastic#75819)" (elastic#76707)
  [Security Solution][Detections] Removes ML Job Settings SIEM copy and fixes link to ML app for creating custom jobs (elastic#76595)
  [Maps] remove region/coordinate-maps visualizations from sample data (elastic#76399)
  [DOCS] Dashboard-first docs refresh (elastic#76194)
  Updated ServiceNow description in docs and actions management UI to contains correct info (elastic#76344)
  [DOCS] Identifies cloud settings in reporting (elastic#76691)
  [Security Solution] Refactor timeline details to use search strategy (elastic#75591)
  es-archiver: Drop invalid index settings, support --query flag  (elastic#76522)
  [DOCS] Identifies graph settings available on cloud (elastic#76661)
  Add more info about a11y tests (elastic#76045)
  [data.search.SearchSource] Remove legacy ES client APIs. (elastic#75943)
  [release notes] automatically retry on Github API 5xx errors (elastic#76447)
  [es_ui_shared] Fix eslint exhaustive deps rule (elastic#76392)
  ...
spong added a commit that referenced this pull request Sep 4, 2020
@spong
[Security Solution][Detections] Removes ML Job Settings SIEM copy and…
c86e93e 
… fixes link to ML app for creating custom jobs (#76595) (#76720)

## Summary

Resolves elastic/security-team#199

Removes remaining SIEM copy and fixes link to ML app for creating custom jobs

<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/92073438-e017d600-ed70-11ea-9827-7b5c9ffab7b1.gif" />
</p>



### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
spong added a commit that referenced this pull request Sep 4, 2020
@spong
[Security Solution][Detections] Removes ML Job Settings SIEM copy and…
2cb943e 
… fixes link to ML app for creating custom jobs (#76595) (#76721)

## Summary

Resolves elastic/security-team#199

Removes remaining SIEM copy and fixes link to ML app for creating custom jobs

<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/92073438-e017d600-ed70-11ea-9827-7b5c9ffab7b1.gif" />
</p>



### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@ghost
Copy link

ghost commented Sep 16, 2020

Hi @spong

We have validated this ticket on "7.9.2 Snapshot" Elastic Staging Cloud Environment and found it Fixed.

Build Details:
Elastic Version : 7.9.2 SNAPSHOT

Changes Fixed :

  • Text "Security Machine" displayed instead of old name"SIEM" on Machine Learning pop-up.

image

  • User is navigated to 'Create job' page after clicking on "Create Custom Job".

image

image

thanks !!

@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley14 dhurley14 dhurley14 approved these changes

Assignees

@spong spong

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.2 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spong @elasticmachine @kibanamachine @dhurley14 @MindyRS