Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ServiceNow description in docs and actions management UI to contains correct info #76344

Merged

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Sep 1, 2020

In management and Case UI description is Create an incident in ServiceNow
img

Resolve #75072

…t create UI to contains correct info that ServiceNow
@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0 labels Sep 1, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner September 1, 2020 01:03
@YulNaumenko YulNaumenko self-assigned this Sep 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote self-requested a review September 2, 2020 19:48
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the case application would be ok using the same description we provide? I can see consumerSelectedMessage not scaling if ever observability also wants to put their own message as well.

@YulNaumenko
Copy link
Contributor Author

I wonder if the case application would be ok using the same description we provide? I can see consumerSelectedMessage not scaling if ever observability also wants to put their own message as well.

It we might be OK with having the same for both Case and Alerting to be just Create an incident.
My first thought was about different behavior of ServiceNow in Case app and Alerting, but for the less confusing UX will be better to have the same title 'Create an incident in ServiceNow.'

@YulNaumenko YulNaumenko requested a review from mikecote September 3, 2020 00:20
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
triggers_actions_ui 264.1KB -19.0B 264.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko YulNaumenko merged commit 60986d4 into elastic:master Sep 3, 2020
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Sep 3, 2020
…ontains correct info (elastic#76344)

* Updated ServiceNow description in documentation and Actions management create UI to contains correct info that ServiceNow

* fixed due to comments
YulNaumenko added a commit that referenced this pull request Sep 3, 2020
…ontains correct info (#76344) (#76704)

* Updated ServiceNow description in documentation and Actions management create UI to contains correct info that ServiceNow

* fixed due to comments
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 4, 2020
…rok/new-patterns-component-use-array

* 'master' of github.com:elastic/kibana: (75 commits)
  Remove legacy ui-apps-mixin (elastic#76604)
  remove unused test_utils (elastic#76528)
  [ML] Functional tests - add UI permission tests (elastic#76368)
  [APM] @ts-error -> @ts-expect-error (elastic#76492)
  [APM] Avoid negative offset for error marker on timeline (elastic#76638)
  [Reporting] rename interfaces to align with task manager integration (elastic#76716)
  Revert back ESO migration for alerting, added try/catch logic to avoid failing Kibana on start (elastic#76220)
  Test reverting "Add plugin status API (elastic#75819)" (elastic#76707)
  [Security Solution][Detections] Removes ML Job Settings SIEM copy and fixes link to ML app for creating custom jobs (elastic#76595)
  [Maps] remove region/coordinate-maps visualizations from sample data (elastic#76399)
  [DOCS] Dashboard-first docs refresh (elastic#76194)
  Updated ServiceNow description in docs and actions management UI to contains correct info (elastic#76344)
  [DOCS] Identifies cloud settings in reporting (elastic#76691)
  [Security Solution] Refactor timeline details to use search strategy (elastic#75591)
  es-archiver: Drop invalid index settings, support --query flag  (elastic#76522)
  [DOCS] Identifies graph settings available on cloud (elastic#76661)
  Add more info about a11y tests (elastic#76045)
  [data.search.SearchSource] Remove legacy ES client APIs. (elastic#75943)
  [release notes] automatically retry on Github API 5xx errors (elastic#76447)
  [es_ui_shared] Fix eslint exhaustive deps rule (elastic#76392)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update some connector descriptions
4 participants