[Canvas] i18n for page manager, page preview, and shape preview (#46865)

* i18n for page manager, page preview, and shape preview * Addressing feedback * Forgot to remove ShapePreview
elastic · Oct 3, 2019 · 4a867a1 · 4a867a1
1 parent 8d2bc28
commit 4a867a1
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 6 deletions.
diff --git a/x-pack/legacy/plugins/canvas/i18n/components.ts b/x-pack/legacy/plugins/canvas/i18n/components.ts
@@ -214,6 +214,33 @@ export const ComponentStrings = {
         defaultMessage: 'Closes keyboard shortcuts reference',
       }),
   },
+  PageManager: {
+    getPageNumberAriaLabel: (pageNumber: number) =>
+      i18n.translate('xpack.canvas.pageManager.pageNumberAriaLabel', {
+        defaultMessage: 'Load page number {pageNumber}',
+        values: {
+          pageNumber,
+        },
+      }),
+  },
+  PagePreviewPageControls: {
+    getClonePageAriaLabel: () =>
+      i18n.translate('xpack.canvas.pagePreviewPageControls.clonePageAriaLabel', {
+        defaultMessage: 'Clone page',
+      }),
+    getClonePageTooltip: () =>
+      i18n.translate('xpack.canvas.pagePreviewPageControls.clonePageTooltip', {
+        defaultMessage: 'Clone',
+      }),
+    getDeletePageAriaLabel: () =>
+      i18n.translate('xpack.canvas.pagePreviewPageControls.deletePageAriaLabel', {
+        defaultMessage: 'Delete page',
+      }),
+    getDeletePageTooltip: () =>
+      i18n.translate('xpack.canvas.pagePreviewPageControls.deletePageTooltip', {
+        defaultMessage: 'Delete',
+      }),
+  },
   Toolbar: {
     getEditorButtonLabel: () =>
       i18n.translate('xpack.canvas.toolbar.editorButtonLabel', {

diff --git a/x-pack/legacy/plugins/canvas/public/components/page_manager/page_manager.js b/x-pack/legacy/plugins/canvas/public/components/page_manager/page_manager.js
@@ -13,6 +13,10 @@ import { ConfirmModal } from '../confirm_modal';
 import { Link } from '../link';
 import { PagePreview } from '../page_preview';
 
+import { ComponentStrings } from '../../../i18n';
+
+const { PageManager: strings } = ComponentStrings;
+
 export class PageManager extends React.PureComponent {
   static propTypes = {
     isWriteable: PropTypes.bool.isRequired,
@@ -154,7 +158,7 @@ export class PageManager extends React.PureComponent {
                 <Link
                   name="loadWorkpad"
                   params={{ id: workpadId, page: pageNumber }}
-                  aria-label={`Load page number ${pageNumber}`}
+                  aria-label={strings.getPageNumberAriaLabel(pageNumber)}
                 >
                   {Style.it(
                     workpadCSS,

diff --git a/x-pack/legacy/plugins/canvas/public/components/page_preview/page_controls.js b/x-pack/legacy/plugins/canvas/public/components/page_preview/page_controls.js
@@ -8,6 +8,10 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import { EuiFlexGroup, EuiFlexItem, EuiButtonIcon, EuiToolTip } from '@elastic/eui';
 
+import { ComponentStrings } from '../../../i18n';
+
+const { PagePreviewPageControls: strings } = ComponentStrings;
+
 export const PageControls = ({ pageId, onDelete, onDuplicate }) => {
   const handleDuplicate = ev => {
     ev.preventDefault();
@@ -26,20 +30,20 @@ export const PageControls = ({ pageId, onDelete, onDuplicate }) => {
       justifyContent="spaceBetween"
     >
       <EuiFlexItem grow={false}>
-        <EuiToolTip content="Duplicate">
+       <EuiToolTip content={strings.getClonePageTooltip()}>
           <EuiButtonIcon
-            iconType="document"
-            aria-label="Duplicate Page"
+            iconType="copy"
+            aria-label={strings.getClonePageAriaLabel()}
             onClick={handleDuplicate}
           />
         </EuiToolTip>
       </EuiFlexItem>
       <EuiFlexItem grow={false}>
-        <EuiToolTip content="Delete">
+        <EuiToolTip content={strings.getDeletePageTooltip()}>
           <EuiButtonIcon
             color="danger"
             iconType="trash"
-            aria-label="Delete Page"
+            aria-label={strings.getDeletePageAriaLabel()}
             onClick={handleDelete}
           />
         </EuiToolTip>