Skip to content

Commit

Permalink
[Integrations] Added link in old Add Data description and fixed align…
Browse files Browse the repository at this point in the history
…ment in cards (#116213) (#116382)

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
  • Loading branch information
kibanamachine and cchaos authored Oct 27, 2021
1 parent a2294e2 commit 696825f
Show file tree
Hide file tree
Showing 6 changed files with 55 additions and 96 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import _ from 'lodash';
import React from 'react';
import PropTypes from 'prop-types';
import { EuiFlexItem, EuiFlexGrid, EuiFlexGroup } from '@elastic/eui';
import { EuiFlexItem, EuiFlexGrid, EuiFlexGroup, EuiLink } from '@elastic/eui';
import { injectI18n, FormattedMessage } from '@kbn/i18n/react';
import { i18n } from '@kbn/i18n';
import { Synopsis } from './synopsis';
Expand Down Expand Up @@ -224,7 +224,17 @@ class TutorialDirectoryUi extends React.Component {
description: (
<FormattedMessage
id="home.tutorial.addDataToKibanaDescription"
defaultMessage="In addition to adding integrations, you can try our sample data, or upload your own data."
defaultMessage="In addition to adding {integrationsLink}, you can try our sample data or upload your own data."
values={{
integrationsLink: (
<EuiLink href={this.props.addBasePath(`/app/integrations/browse`)}>
<FormattedMessage
id="home.tutorial.addDataToKibanaDescription.integrations"
defaultMessage="integrations"
/>
</EuiLink>
),
}}
/>
),
tabs,
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ export const ElasticAgentCard: FunctionComponent<ElasticAgentCardProps> = ({
<EuiCard
paddingSize="l"
image={image}
textAlign="left"
title={
<EuiTextColor color="default">
{i18n.translate('kibana-react.noDataPage.elasticAgentCard.noPermission.title', {
Expand Down Expand Up @@ -93,12 +92,7 @@ export const ElasticAgentCard: FunctionComponent<ElasticAgentCardProps> = ({
defaultMessage: `Use Elastic Agent for a simple, unified way to collect data from your machines.`,
})}
betaBadgeLabel={recommended ? NO_DATA_RECOMMENDED : undefined}
footer={
<div className="eui-textCenter">
{button}
{footer}
</div>
}
footer={footer}
layout={layout as 'vertical' | undefined}
{...cardRest}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,14 @@ export const NoDataCard: FunctionComponent<NoDataPageActions> = ({
return (
<EuiCard
paddingSize="l"
textAlign="left"
// TODO: we should require both title and description to be passed in by consumers since defaults are not adequate.
// see comment: https://github.com/elastic/kibana/pull/111261/files#r708399140
title={title!}
description={i18n.translate('kibana-react.noDataPage.noDataCard.description', {
defaultMessage: `Proceed without collecting data`,
})}
betaBadgeLabel={recommended ? NO_DATA_RECOMMENDED : undefined}
footer={<div className="eui-textCenter">{footer}</div>}
footer={footer}
layout={layout as 'vertical' | undefined}
{...cardRest}
/>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.kbnNoDataPageContents__item:only-child {
min-width: 400px;
min-width: ($euiSize * 22.5);

@include euiBreakpoint('xs', 's') {
min-width: auto;
Expand Down

0 comments on commit 696825f

Please sign in to comment.