[Integrations] Added link in old Add Data description and fixed alignment in cards #116213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
added
v8.0.0
auto-backport
lukeelmers
approved these changes
Oct 25, 2021
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 26, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
jloleysens
reviewed
Oct 27, 2021
| @@ -93,12 +92,7 @@ export const ElasticAgentCard: FunctionComponent<ElasticAgentCardProps> = ({ | |||
| defaultMessage: `Use Elastic Agent for a simple, unified way to collect data from your machines.`, | |||
| })} | |||
| betaBadgeLabel={recommended ? NO_DATA_RECOMMENDED : undefined} | |||
| footer={ | |||
| <div className="eui-textCenter"> | |||
| {button} | |||
There was a problem hiding this comment.
Sorry if this is a dumb question, but where is this button now?
There was a problem hiding this comment.
The footer always contained the button so this would have actually duplicated it if the button was configured.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 27, 2021
…-migrate-away-from-injected-css-js * 'master' of github.com:elastic/kibana: (61 commits) [ML] Nodes overview for the Model Management page (elastic#116361) [Uptime] Uptime index config using kibana.yml (elastic#115775) [Controls] Dashboard Integration (elastic#115991) skip flaky suite (elastic#104260) Include Files in GitHub UI (elastic#115956) skip flaky suite (elastic#116060) [Canvas] By-Value Embeddables (elastic#113827) Skip failing test (elastic#115366) [Osquery] Fix live query search doesn't return relevant results for agents (elastic#116332) [Integrations] Added link in old Add Data description and fixed alignment in cards (elastic#116213) [Actions] Extended ActionTypeRegistry with connector validation to validate config with secrets (elastic#116079) skip flaky suite (elastic#109329) Grant access to machine learning features when base privileges are used (elastic#115444) Skipping failing test (elastic#84957) [RAC][Security Solution] Adds migration to new SecuritySolution rule types (elastic#112113) skip flaky suite (elastic#115366) [Fleet] Marking API spec as experimental (elastic#116331) [Docs] Cleaning up the versions in the upgrade paths. Closes elastic#116223 (elastic#116228) [Reporting] Suppress debug logs in the mock logger (elastic#116012) [Metrics UI] Clear threshold alert groups state when filterQuery changes (elastic#116205) ... # Conflicts: # src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx # src/plugins/dashboard/public/types.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added link
In case users ended up at Sample Data without having gone through integrations, we probably still want to steer them there. So I applied the integrations link to the
integrationstext in the description.Changed text alignment of all No Data cards back to center
I know this was a contentious design decision stemming from #115495, but the mismatch of left aligned text and center aligned buttons was harder to read. There was also a mismatch in logic where the "No privileges" one was left aligned, but the regular one was centered with extra wrapping divs in the footer that weren't necessary.
Basically this reverts those custom styles. Sorry. We can revisit later, but I didn't see an improvement over how it was before. It also doesn't actually change how the regular card was rendering.
Also, I fixed the known orphan from the "no privileges" version by making the min-width a tad smaller.
Checklist
Delete any items that are not applicable to this PR.