Skip to content

Commit

Permalink
Flaky test fix for Actions and Triggers app alerts should delete all …
Browse files Browse the repository at this point in the history
…selection (#86175)

* Removed skip test for delete all alerts integration test

* fixed typechecks

* reduced nuber of selected alert to delete to a single one

* fixed due to comments

* removed long timing retry

* fixed typechecks

* fixed failing tests
  • Loading branch information
YulNaumenko authored Jan 5, 2021
1 parent b9a72fe commit 9d12b1c
Showing 1 changed file with 5 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* you may not use this file except in compliance with the Elastic License.
*/

import { times } from 'lodash';
import expect from '@kbn/expect';
import { FtrProviderContext } from '../../ftr_provider_context';
import { ObjectRemover } from '../../lib/object_remover';
Expand Down Expand Up @@ -322,18 +321,13 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
expect(isChecked).to.eql('false');
});

it.skip('should delete all selection', async () => {
it('should delete all selection', async () => {
const namePrefix = generateUniqueKey();
let count = 0;
const createdAlertsFirstPage = await Promise.all(
times(2, () => createAlertManualCleanup({ name: `${namePrefix}-0${count++}` }))
);
const createdAlert = await createAlertManualCleanup({ name: `${namePrefix}-1` });
await refreshAlertsList();
await pageObjects.triggersActionsUI.searchAlerts(namePrefix);

for (const createdAlert of createdAlertsFirstPage) {
await testSubjects.click(`checkboxSelectRow-${createdAlert.id}`);
}
await testSubjects.click(`checkboxSelectRow-${createdAlert.id}`);

await testSubjects.click('bulkAction');

Expand All @@ -342,9 +336,9 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await testSubjects.click('deleteIdsConfirmation > confirmModalConfirmButton');
await testSubjects.missingOrFail('deleteIdsConfirmation');

await retry.tryForTime(30000, async () => {
await retry.try(async () => {
const toastTitle = await pageObjects.common.closeToast();
expect(toastTitle).to.eql('Deleted 2 alerts');
expect(toastTitle).to.eql('Deleted 1 alert');
});

await pageObjects.triggersActionsUI.searchAlerts(namePrefix);
Expand Down

0 comments on commit 9d12b1c

Please sign in to comment.