Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test fix for Actions and Triggers app alerts should delete all selection #86175

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Dec 16, 2020

  1. Added cleanup logic to details page tests.
  2. Reduced number of selected alerts to a one - should do only one api call now (same as non flaky Delete single has). It should solve a flakiness for this test till we implement a [bulk delete operation].(Bulk create, update, delete abilities for the rules client #53144).
    Resolve Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts·ts - Actions and Triggers app alerts should delete all selection #77401.

@YulNaumenko YulNaumenko added bug Fixes for quality problems that affect the customer experience Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Dec 16, 2020
@YulNaumenko YulNaumenko self-assigned this Dec 16, 2020
@YulNaumenko YulNaumenko marked this pull request as ready for review December 17, 2020 20:35
@YulNaumenko YulNaumenko requested a review from a team as a code owner December 17, 2020 20:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good so far. It looks like there's still some flakiness so I will wait on finishing my review.

@@ -349,11 +349,11 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await deleteAlerts([createdAlert.id]);
});

it.skip('should delete all selection', async () => {
it('should delete all selection', async () => {
const namePrefix = generateUniqueKey();
let count = 0;
const createdAlertsFirstPage = await Promise.all(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're only creating one alert, we can cleanup some of the looping logic at the same time.

Suggested change
const createdAlertsFirstPage = await Promise.all(
const createdAlert = await createAlert({ name: `${namePrefix}-1` });

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47252 48012 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YulNaumenko YulNaumenko merged commit 9d12b1c into elastic:master Jan 5, 2021
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Jan 5, 2021
…selection (elastic#86175)

* Removed skip test for delete all alerts integration test

* fixed typechecks

* reduced nuber of selected alert to delete to a single one

* fixed due to comments

* removed long timing retry

* fixed typechecks

* fixed failing tests
YulNaumenko added a commit that referenced this pull request Jan 5, 2021
…selection (#86175) (#87366)

* Removed skip test for delete all alerts integration test

* fixed typechecks

* reduced nuber of selected alert to delete to a single one

* fixed due to comments

* removed long timing retry

* fixed typechecks

* fixed failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v7.12.0 v8.0.0
Projects
None yet
5 participants