-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky test fix for Actions and Triggers app alerts should delete all selection #86175
Flaky test fix for Actions and Triggers app alerts should delete all selection #86175
Conversation
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good so far. It looks like there's still some flakiness so I will wait on finishing my review.
@@ -349,11 +349,11 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { | |||
await deleteAlerts([createdAlert.id]); | |||
}); | |||
|
|||
it.skip('should delete all selection', async () => { | |||
it('should delete all selection', async () => { | |||
const namePrefix = generateUniqueKey(); | |||
let count = 0; | |||
const createdAlertsFirstPage = await Promise.all( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're only creating one alert, we can cleanup some of the looping logic at the same time.
const createdAlertsFirstPage = await Promise.all( | |
const createdAlert = await createAlert({ name: `${namePrefix}-1` }); |
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…selection (elastic#86175) * Removed skip test for delete all alerts integration test * fixed typechecks * reduced nuber of selected alert to delete to a single one * fixed due to comments * removed long timing retry * fixed typechecks * fixed failing tests
Resolve Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts·ts - Actions and Triggers app alerts should delete all selection #77401.