[Observability] [Cases] Cases in the observability app (#101487)

elastic · Jun 10, 2021 · 9d7af06 · 9d7af06
1 parent d0188d6
commit 9d7af06
Show file tree

Hide file tree

Showing 82 changed files with 2,949 additions and 206 deletions.
diff --git a/src/plugins/kibana_usage_collection/server/collectors/application_usage/schema.ts b/src/plugins/kibana_usage_collection/server/collectors/application_usage/schema.ts
@@ -148,6 +148,7 @@ export const applicationUsageSchema = {
  maps: commonSchema,
  ml: commonSchema,
  monitoring: commonSchema,
+ observabilityCases: commonSchema,
  'observability-overview': commonSchema,
  osquery: commonSchema,
  security_account: commonSchema,

diff --git a/src/plugins/telemetry/schema/oss_plugins.json b/src/plugins/telemetry/schema/oss_plugins.json
@@ -3970,6 +3970,137 @@
  }
  }
  },
+ "observabilityCases": {
+ "properties": {
+ "appId": {
+ "type": "keyword",
+ "_meta": {
+ "description": "The application being tracked"
+ }
+ },
+ "viewId": {
+ "type": "keyword",
+ "_meta": {
+ "description": "Always `main`"
+ }
+ },
+ "clicks_total": {
+ "type": "long",
+ "_meta": {
+ "description": "General number of clicks in the application since we started counting them"
+ }
+ },
+ "clicks_7_days": {
+ "type": "long",
+ "_meta": {
+ "description": "General number of clicks in the application over the last 7 days"
+ }
+ },
+ "clicks_30_days": {
+ "type": "long",
+ "_meta": {
+ "description": "General number of clicks in the application over the last 30 days"
+ }
+ },
+ "clicks_90_days": {
+ "type": "long",
+ "_meta": {
+ "description": "General number of clicks in the application over the last 90 days"
+ }
+ },
+ "minutes_on_screen_total": {
+ "type": "float",
+ "_meta": {
+ "description": "Minutes the application is active and on-screen since we started counting them."
+ }
+ },
+ "minutes_on_screen_7_days": {
+ "type": "float",
+ "_meta": {
+ "description": "Minutes the application is active and on-screen over the last 7 days"
+ }
+ },
+ "minutes_on_screen_30_days": {
+ "type": "float",
+ "_meta": {
+ "description": "Minutes the application is active and on-screen over the last 30 days"
+ }
+ },
+ "minutes_on_screen_90_days": {
+ "type": "float",
+ "_meta": {
+ "description": "Minutes the application is active and on-screen over the last 90 days"
+ }
+ },
+ "views": {
+ "type": "array",
+ "items": {
+ "properties": {
+ "appId": {
+ "type": "keyword",
+ "_meta": {
+ "description": "The application being tracked"
+ }
+ },
+ "viewId": {
+ "type": "keyword",
+ "_meta": {
+ "description": "The application view being tracked"
+ }
+ },
+ "clicks_total": {
+ "type": "long",
+ "_meta": {
+ "description": "General number of clicks in the application sub view since we started counting them"
+ }
+ },
+ "clicks_7_days": {
+ "type": "long",
+ "_meta": {
+ "description": "General number of clicks in the active application sub view over the last 7 days"
+ }
+ },
+ "clicks_30_days": {
+ "type": "long",
+ "_meta": {
+ "description": "General number of clicks in the active application sub view over the last 30 days"
+ }
+ },
+ "clicks_90_days": {
+ "type": "long",
+ "_meta": {
+ "description": "General number of clicks in the active application sub view over the last 90 days"
+ }
+ },
+ "minutes_on_screen_total": {
+ "type": "float",
+ "_meta": {
+ "description": "Minutes the application sub view is active and on-screen since we started counting them."
+ }
+ },
+ "minutes_on_screen_7_days": {
+ "type": "float",
+ "_meta": {
+ "description": "Minutes the application is active and on-screen active application sub view over the last 7 days"
+ }
+ },
+ "minutes_on_screen_30_days": {
+ "type": "float",
+ "_meta": {
+ "description": "Minutes the application is active and on-screen active application sub view over the last 30 days"
+ }
+ },
+ "minutes_on_screen_90_days": {
+ "type": "float",
+ "_meta": {
+ "description": "Minutes the application is active and on-screen active application sub view over the last 90 days"
+ }
+ }
+ }
+ }
+ }
+ }
+ },
  "observability-overview": {
  "properties": {
  "appId": {

diff --git a/test/functional/config.js b/test/functional/config.js
@@ -95,6 +95,9 @@ export default async function ({ readConfigFile }) {
  pathname: '/app/home',
  hash: '/',
  },
+ observabilityCases: {
+ pathname: '/app/observability/cases',
+ },
  },
  junit: {
  reportName: 'Chrome UI Functional Tests',

diff --git a/x-pack/plugins/cases/public/components/all_cases/all_cases_generic.tsx b/x-pack/plugins/cases/public/components/all_cases/all_cases_generic.tsx
@@ -62,9 +62,11 @@ interface AllCasesGenericProps {
  caseDetailsNavigation?: CasesNavigation<CaseDetailsHrefSchema, 'configurable'>; // if not passed, case name is not displayed as a link (Formerly dependant on isSelectorView)
  configureCasesNavigation?: CasesNavigation; // if not passed, header with nav is not displayed (Formerly dependant on isSelectorView)
  createCaseNavigation: CasesNavigation;
+ disableAlerts?: boolean;
  hiddenStatuses?: CaseStatusWithAllStatus[];
  isSelectorView?: boolean;
  onRowClick?: (theCase?: Case | SubCase) => void;
+ showTitle?: boolean;
  updateCase?: (newCase: Case) => void;
  userCanCrud: boolean;
 }
@@ -75,9 +77,11 @@ export const AllCasesGeneric = React.memo<AllCasesGenericProps>(
  caseDetailsNavigation,
  configureCasesNavigation,
  createCaseNavigation,
+ disableAlerts,
  hiddenStatuses = [],
  isSelectorView,
  onRowClick,
+ showTitle,
  updateCase,
  userCanCrud,
  }) => {
@@ -190,6 +194,7 @@ export const AllCasesGeneric = React.memo<AllCasesGenericProps>(
 
  const columns = useCasesColumns({
  caseDetailsNavigation,
+ disableAlerts,
  dispatchUpdateCaseProperty,
  filterStatus: filterOptions.status,
  handleIsLoading,
@@ -271,6 +276,7 @@ export const AllCasesGeneric = React.memo<AllCasesGenericProps>(
  createCaseNavigation={createCaseNavigation}
  configureCasesNavigation={configureCasesNavigation}
  refresh={refresh}
+ showTitle={showTitle}
  userCanCrud={userCanCrud}
  />
  )}

diff --git a/x-pack/plugins/cases/public/components/all_cases/columns.tsx b/x-pack/plugins/cases/public/components/all_cases/columns.tsx
@@ -55,6 +55,7 @@ const renderStringField = (field: string, dataTestSubj: string) =>
 
 export interface GetCasesColumn {
  caseDetailsNavigation?: CasesNavigation<CaseDetailsHrefSchema, 'configurable'>;
+ disableAlerts?: boolean;
  dispatchUpdateCaseProperty: (u: UpdateCase) => void;
  filterStatus: string;
  handleIsLoading: (a: boolean) => void;
@@ -64,6 +65,7 @@ export interface GetCasesColumn {
 }
 export const useCasesColumns = ({
  caseDetailsNavigation,
+ disableAlerts = false,
  dispatchUpdateCaseProperty,
  filterStatus,
  handleIsLoading,
@@ -203,15 +205,19 @@ export const useCasesColumns = ({
  },
  truncateText: true,
  },
- {
- align: RIGHT_ALIGNMENT,
- field: 'totalAlerts',
- name: ALERTS,
- render: (totalAlerts: Case['totalAlerts']) =>
- totalAlerts != null
- ? renderStringField(`${totalAlerts}`, `case-table-column-alertsCount`)
- : getEmptyTagValue(),
- },
+ ...(!disableAlerts
+ ? [
+ {
+ align: RIGHT_ALIGNMENT,
+ field: 'totalAlerts',
+ name: ALERTS,
+ render: (totalAlerts: Case['totalAlerts']) =>
+ totalAlerts != null
+ ? renderStringField(`${totalAlerts}`, `case-table-column-alertsCount`)
+ : getEmptyTagValue(),
+ },
+ ]
+ : []),
  {
  align: RIGHT_ALIGNMENT,
  field: 'totalComment',

diff --git a/x-pack/plugins/cases/public/components/all_cases/header.tsx b/x-pack/plugins/cases/public/components/all_cases/header.tsx
@@ -20,6 +20,7 @@ interface OwnProps {
  configureCasesNavigation: CasesNavigation;
  createCaseNavigation: CasesNavigation;
  refresh: number;
+ showTitle?: boolean;
  userCanCrud: boolean;
 }
 
@@ -40,9 +41,10 @@ export const CasesTableHeader: FunctionComponent<Props> = ({
  configureCasesNavigation,
  createCaseNavigation,
  refresh,
+ showTitle = true,
  userCanCrud,
 }) => (
- <CaseHeaderPage title={i18n.PAGE_TITLE}>
+ <CaseHeaderPage title={showTitle ? i18n.PAGE_TITLE : ''}>
  <EuiFlexGroup
  alignItems="center"
  gutterSize="m"

diff --git a/x-pack/plugins/cases/public/components/all_cases/index.tsx b/x-pack/plugins/cases/public/components/all_cases/index.tsx
@@ -14,6 +14,8 @@ export interface AllCasesProps extends Owner {
  caseDetailsNavigation: CasesNavigation<CaseDetailsHrefSchema, 'configurable'>; // if not passed, case name is not displayed as a link (Formerly dependant on isSelector)
  configureCasesNavigation: CasesNavigation; // if not passed, header with nav is not displayed (Formerly dependant on isSelector)
  createCaseNavigation: CasesNavigation;
+ disableAlerts?: boolean;
+ showTitle?: boolean;
  userCanCrud: boolean;
 }
 

diff --git a/x-pack/plugins/cases/public/components/callout/callout.test.tsx b/x-pack/plugins/cases/public/components/callout/callout.test.tsx
@@ -80,7 +80,7 @@ describe('Callout', () => {
  });
 
  it('dismiss the callout correctly', () => {
- const wrapper = mount(<CallOut {...defaultProps} messages={[]} />);
+ const wrapper = mount(<CallOut {...defaultProps} />);
  expect(wrapper.find(`[data-test-subj="callout-dismiss-md5-hex"]`).exists()).toBeTruthy();
  wrapper.find(`button[data-test-subj="callout-dismiss-md5-hex"]`).simulate('click');
  wrapper.update();

diff --git a/x-pack/plugins/cases/public/components/callout/callout.tsx b/x-pack/plugins/cases/public/components/callout/callout.tsx
@@ -35,11 +35,9 @@ const CallOutComponent = ({
  type,
  ]);
 
- return showCallOut ? (
+ return showCallOut && !isEmpty(messages) ? (
  <EuiCallOut title={title} color={type} iconType="gear" data-test-subj={`case-callout-${id}`}>
- {!isEmpty(messages) && (
- <EuiDescriptionList data-test-subj={`callout-messages-${id}`} listItems={messages} />
- )}
+ <EuiDescriptionList data-test-subj={`callout-messages-${id}`} listItems={messages} />
  <EuiButton
  data-test-subj={`callout-dismiss-${id}`}
  color={type === 'success' ? 'secondary' : type}

diff --git a/x-pack/plugins/cases/public/components/callout/helpers.tsx b/x-pack/plugins/cases/public/components/callout/helpers.tsx
@@ -11,7 +11,7 @@ import md5 from 'md5';
 import * as i18n from './translations';
 import { ErrorMessage } from './types';
 
-export const savedObjectReadOnlyErrorMessage: ErrorMessage = {
+export const permissionsReadOnlyErrorMessage: ErrorMessage = {
  id: 'read-only-privileges-error',
  title: i18n.READ_ONLY_FEATURE_TITLE,
  description: <>{i18n.READ_ONLY_FEATURE_MSG}</>,

diff --git a/x-pack/plugins/cases/public/components/case_action_bar/actions.test.tsx b/x-pack/plugins/cases/public/components/case_action_bar/actions.test.tsx
@@ -26,7 +26,14 @@ jest.mock('react-router-dom', () => {
  }),
  };
 });
-
+const defaultProps = {
+ allCasesNavigation: {
+ href: 'all-cases-href',
+ onClick: () => {},
+ },
+ caseData: basicCase,
+ currentExternalIncident: null,
+};
 describe('CaseView actions', () => {
  const handleOnDeleteConfirm = jest.fn();
  const handleToggleModal = jest.fn();
@@ -49,7 +56,7 @@ describe('CaseView actions', () => {
  it('clicking trash toggles modal', () => {
  const wrapper = mount(
  <TestProviders>
- <Actions caseData={basicCase} currentExternalIncident={null} />
+ <Actions {...defaultProps} />
  </TestProviders>
  );
 
@@ -67,7 +74,7 @@ describe('CaseView actions', () => {
  }));
  const wrapper = mount(
  <TestProviders>
- <Actions caseData={basicCase} currentExternalIncident={null} />
+ <Actions {...defaultProps} />
  </TestProviders>
  );
 
@@ -82,7 +89,7 @@ describe('CaseView actions', () => {
  const wrapper = mount(
  <TestProviders>
  <Actions
- caseData={basicCase}
+ {...defaultProps}
  currentExternalIncident={{
  ...basicPush,
  firstPushIndex: 5,

diff --git a/x-pack/plugins/cases/public/components/case_action_bar/actions.tsx b/x-pack/plugins/cases/public/components/case_action_bar/actions.tsx
@@ -7,26 +7,27 @@
 
 import { isEmpty } from 'lodash/fp';
 import React, { useMemo } from 'react';
-import { useHistory } from 'react-router-dom';
 import * as i18n from '../case_view/translations';
 import { useDeleteCases } from '../../containers/use_delete_cases';
 import { ConfirmDeleteCaseModal } from '../confirm_delete_case';
 import { PropertyActions } from '../property_actions';
-import { Case } from '../../containers/types';
+import { Case } from '../../../common';
 import { CaseService } from '../../containers/use_get_case_user_actions';
+import { CasesNavigation } from '../links';
 
 interface CaseViewActions {
+ allCasesNavigation: CasesNavigation;
  caseData: Case;
  currentExternalIncident: CaseService | null;
  disabled?: boolean;
 }
 
 const ActionsComponent: React.FC<CaseViewActions> = ({
+ allCasesNavigation,
  caseData,
  currentExternalIncident,
  disabled = false,
 }) => {
- const history = useHistory();
  // Delete case
  const {
  handleToggleModal,
@@ -57,7 +58,7 @@ const ActionsComponent: React.FC<CaseViewActions> = ({
  );
 
  if (isDeleted) {
- history.push('/');
+ allCasesNavigation.onClick(null);
  return null;
  }
  return (

diff --git a/x-pack/plugins/cases/public/components/case_action_bar/index.test.tsx b/x-pack/plugins/cases/public/components/case_action_bar/index.test.tsx
@@ -16,7 +16,12 @@ describe('CaseActionBar', () => {
  const onRefresh = jest.fn();
  const onUpdateField = jest.fn();
  const defaultProps = {
+ allCasesNavigation: {
+ href: 'all-cases-href',
+ onClick: () => {},
+ },
  caseData: basicCase,
+ disableAlerting: false,
  isLoading: false,
  onRefresh,
  onUpdateField,