-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SecuritySolution] Fix data view not found when rendering with adHocD…
…ataView (#149513) ## Summary Please Enable feature flags. Please add this to kibana.dev.yml xpack.securitySolution.enableExperimental: ['chartEmbeddablesEnabled'] <img width="1513" alt="Screenshot 2023-01-25 at 12 54 54" src="https://user-images.githubusercontent.com/6295984/214573163-1e606e07-c7c6-4980-99c5-0ce4347fb6c0.png"> AdHocDataview requires a static reference to point internal reference Id to the given data view. The reference of data view will be lost If we re-generate internal reference Id every time the function is called. To fix this, I assigned the id out side of the function so it wouldn't change when the function is called. Expected: Risk score over time should be rendered properly: <img width="1501" alt="Screenshot 2023-01-25 at 13 42 56" src="https://user-images.githubusercontent.com/6295984/214578964-06dc8d11-cf65-4ede-a2ba-a42a1268d6e5.png"> <img width="1513" alt="Screenshot 2023-01-25 at 13 43 57" src="https://user-images.githubusercontent.com/6295984/214579194-d64ef60f-28fe-407e-8d71-abb56ef845e4.png"> ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- Loading branch information
Showing
6 changed files
with
49 additions
and
42 deletions.
There are no files selected for viewing
12 changes: 6 additions & 6 deletions
12
...on_actions/lens_attributes/common/risk_scores/__snapshots__/risk_score_donut.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
64 changes: 32 additions & 32 deletions
64
...s/lens_attributes/common/risk_scores/__snapshots__/risk_score_over_time_area.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters