Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution] Fix data view not found when rendering with adHocDataView #149513

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Jan 25, 2023

Summary

Please Enable feature flags. Please add this to kibana.dev.yml xpack.securitySolution.enableExperimental: ['chartEmbeddablesEnabled']

Screenshot 2023-01-25 at 12 54 54

AdHocDataview requires a static reference to point internal reference Id to the given data view.
The reference of data view will be lost If we re-generate internal reference Id every time the function is called.
To fix this, I assigned the id out side of the function so it wouldn't change when the function is called.

Expected: Risk score over time should be rendered properly:

Screenshot 2023-01-25 at 13 42 56

Screenshot 2023-01-25 at 13 43 57

Checklist

Delete any items that are not applicable to this PR.

@angorayc angorayc added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore v8.7.0 labels Jan 25, 2023
@angorayc angorayc changed the title update attributes [SecuritySolution] Fix data view not found when rendering with adHocDataView Jan 25, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.8MB 12.8MB +81.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc marked this pull request as ready for review January 25, 2023 15:49
@angorayc angorayc requested a review from a team as a code owner January 25, 2023 15:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@angorayc angorayc merged commit a3ba276 into elastic:main Jan 25, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants