-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ES UI] Reintroduce import of brace/mode/json (#78571)
* added brace/mode/json import everywhere json mode is being used * added brace mocks to tests * slight refactor of imports * remove import from es ui shared * Reverse adding brace/mode/json import everywhere - different approach of just adding brace/json/mode to es_ui_shared as before with a BIG comment * updated @kbn/ace readme Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
- Loading branch information
1 parent
e95f033
commit c5ab749
Showing
2 changed files
with
32 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,20 @@ | ||
# @kbn/ace | ||
|
||
Contains all Kibana-specific brace related code. Excluding the code that still inside of Console because that code is only used inside of console at the moment. | ||
This package contains the XJSON mode for brace. This is an extension of the `brace/mode/json` mode. | ||
|
||
This package enables plugins to use this functionality and import it as needed -- behind an async import so that brace does not bloat the JS code needed for first page load of Kibana. | ||
This package also contains an import of the entire brace editor which is used for creating the custom XJSON worker. | ||
|
||
## Note to plugins | ||
_This code should not be eagerly loaded_. | ||
|
||
Make sure imports of this package are behind a lazy-load `import()` statement. | ||
|
||
Your plugin should already be loading application code this way in the `mount` function. | ||
|
||
## Deprecated | ||
|
||
This package is considered deprecated and will be removed in future. | ||
|
||
New and existing editor functionality should use Monaco. | ||
|
||
_Do not add new functionality to this package_. Build new functionality for Monaco and use it instead. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters