[ES UI] Reintroduce import of brace/mode/json #78571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
release_note:skip
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
- different approach of just adding brace/json/mode to es_ui_shared as before with a BIG comment
jloleysens
added
the
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
jloleysens
changed the title
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
page load bundle size
History
To update your PR or re-run it, just comment with: |
sebelga
approved these changes
Oct 1, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 1, 2020
* added brace/mode/json import everywhere json mode is being used * added brace mocks to tests * slight refactor of imports * remove import from es ui shared * Reverse adding brace/mode/json import everywhere - different approach of just adding brace/json/mode to es_ui_shared as before with a BIG comment * updated @kbn/ace readme Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens
added a commit
that referenced
this pull request
Oct 1, 2020
* added brace/mode/json import everywhere json mode is being used * added brace mocks to tests * slight refactor of imports * remove import from es ui shared * Reverse adding brace/mode/json import everywhere - different approach of just adding brace/json/mode to es_ui_shared as before with a BIG comment * updated @kbn/ace readme Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After removing brace from the eagerly loaded es_ui_shared plugin (#78033), not all plugins have access to the brace JSON mode that it was also importing.
This contribution re-adds just the brace/mode/json import to es_ui_shared so that it is implicitly available to all plugins in Kibana as before.
See comment in code for more detailed description of reasoning and plan.