[ES UI Shared] Remove 'brace' from es_ui_shared public #78033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved expand and collapse logic back to es_ui_shared. It has nothing to do with ace - refactor the useXJson hook which bundled XJsonMode with it. This was convenient but ultimately inflates the amount of code Kibana needs to first load up in the client. Users will need to import XJsonMode and instantiate it when they want to use it. Updated existing usage. - Cleaned up Monaco namespace from es_ui_shared because of how useXJsonMode was refactored -- no longer exporting an editor specific instance means this code does not know about anything to do with code editors so it is decoupled from ace and monaco.
jloleysens
added
v8.0.0
Team:Kibana Management
|
Nice, I support this approach. It looks like the code is asynchronously loaded by plugins because they are all loading ace in their async bundles and now the code from es_ui_shared is also being loaded async as a by product. Thanks for working to find a good option and I hope that we can start to transition some of the existing ACE usage to monaco in the coming months. |
|
@elasticmachine merge upstream |
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
YulNaumenko
approved these changes
Sep 22, 2020
spalger
approved these changes
Sep 22, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
page load bundle size
distributable file count
History
To update your PR or re-run it, just comment with: |
sebelga
approved these changes
Sep 24, 2020
darnautov
approved these changes
Sep 24, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 24, 2020
* major wip * major wip * fix worker creation leak * just copy the file over for now * Remove xjson from static and from es_ui_shared entirely - moved expand and collapse logic back to es_ui_shared. It has nothing to do with ace - refactor the useXJson hook which bundled XJsonMode with it. This was convenient but ultimately inflates the amount of code Kibana needs to first load up in the client. Users will need to import XJsonMode and instantiate it when they want to use it. Updated existing usage. - Cleaned up Monaco namespace from es_ui_shared because of how useXJsonMode was refactored -- no longer exporting an editor specific instance means this code does not know about anything to do with code editors so it is decoupled from ace and monaco. * fix export of collapse and expand string literals Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # .github/CODEOWNERS # src/plugins/es_ui_shared/kibana.json
jloleysens
added a commit
that referenced
this pull request
Sep 28, 2020
…#78427) * [ES UI Shared] Remove 'brace' from es_ui_shared public (#78033) * major wip * major wip * fix worker creation leak * just copy the file over for now * Remove xjson from static and from es_ui_shared entirely - moved expand and collapse logic back to es_ui_shared. It has nothing to do with ace - refactor the useXJson hook which bundled XJsonMode with it. This was convenient but ultimately inflates the amount of code Kibana needs to first load up in the client. Users will need to import XJsonMode and instantiate it when they want to use it. Updated existing usage. - Cleaned up Monaco namespace from es_ui_shared because of how useXJsonMode was refactored -- no longer exporting an editor specific instance means this code does not know about anything to do with code editors so it is decoupled from ace and monaco. * fix export of collapse and expand string literals Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # .github/CODEOWNERS # src/plugins/es_ui_shared/kibana.json * import brace json mode in raw vis editor Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Actions taken:
src/plugins/es_ui_shared/public/console_langtopackages/kbn-ace, creating@kbn/ace. The primary reason for this move is to reduce the initial amount of JS loaded when first starting Kibana.useXJsonModeto not bundle an editor specific mode with it.import ... 'brace'statements to@kbn/ace.The result of this is a ~50% shrink in es_ui_shared. From
1.9mbto1.0mbunoptimised JS. es_ui_shared will shrink by a further ~30% once #74539 is merged.To plugin owners