-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Uptime] Include synthetics-* for existing alerts (#160063)
(cherry picked from commit a2cc9a6)
- Loading branch information
Showing
12 changed files
with
220 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
176 changes: 176 additions & 0 deletions
176
x-pack/plugins/synthetics/server/legacy_uptime/lib/lib.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,176 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { UptimeEsClient } from './lib'; | ||
| import { savedObjectsClientMock, uiSettingsServiceMock } from '@kbn/core/server/mocks'; | ||
| import { elasticsearchClientMock } from '@kbn/core-elasticsearch-client-server-mocks'; | ||
| import { savedObjectsAdapter } from './saved_objects'; | ||
|
|
||
| describe('UptimeEsClient', () => { | ||
| let uptimeEsClient: UptimeEsClient; | ||
| const savedObjectsClient = savedObjectsClientMock.create(); | ||
| const esClient = elasticsearchClientMock.createClusterClient().asInternalUser; | ||
|
|
||
| beforeEach(() => { | ||
| uptimeEsClient = new UptimeEsClient(savedObjectsClient, esClient); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| jest.clearAllMocks(); | ||
| }); | ||
|
|
||
| describe('search', () => { | ||
| it('should call baseESClient.search with correct parameters', async () => { | ||
| const mockSearchParams = { | ||
| body: { | ||
| query: { | ||
| match_all: {}, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| const result = await uptimeEsClient.search({ | ||
| body: { | ||
| query: { | ||
| match_all: {}, | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| expect(esClient.search).toHaveBeenCalledWith( | ||
| { | ||
| index: 'heartbeat-8*,heartbeat-7*', | ||
| ...mockSearchParams, | ||
| }, | ||
| { meta: true } | ||
| ); | ||
| expect(result).toEqual({ | ||
| body: {}, | ||
| headers: { | ||
| 'x-elastic-product': 'Elasticsearch', | ||
| }, | ||
| meta: {}, | ||
| statusCode: 200, | ||
| warnings: [], | ||
| }); | ||
| }); | ||
|
|
||
| it('should throw an error if baseESClient.search throws an error', async () => { | ||
| const mockSearchParams = { | ||
| body: { | ||
| query: { | ||
| match_all: {}, | ||
| }, | ||
| }, | ||
| }; | ||
| const mockError = new Error('Search error'); | ||
| esClient.search.mockRejectedValueOnce(mockError); | ||
|
|
||
| await expect(uptimeEsClient.search(mockSearchParams)).rejects.toThrow(mockError); | ||
| expect(esClient.search).toHaveBeenCalledWith( | ||
| { | ||
| index: 'heartbeat-8*,heartbeat-7*', | ||
| ...mockSearchParams, | ||
| }, | ||
| { meta: true } | ||
| ); | ||
| }); | ||
| }); | ||
|
|
||
| describe('count', () => { | ||
| it('should call baseESClient.count with correct parameters', async () => { | ||
| const mockCountParams = { | ||
| index: 'example', | ||
| }; | ||
|
|
||
| const result = await uptimeEsClient.count(mockCountParams); | ||
|
|
||
| expect(esClient.count).toHaveBeenCalledWith(mockCountParams, { meta: true }); | ||
| expect(result).toEqual({ | ||
| indices: 'heartbeat-8*,heartbeat-7*', | ||
| result: { | ||
| body: {}, | ||
| headers: { | ||
| 'x-elastic-product': 'Elasticsearch', | ||
| }, | ||
| meta: {}, | ||
| statusCode: 200, | ||
| warnings: [], | ||
| }, | ||
| }); | ||
| }); | ||
|
|
||
| it('should throw an error if baseESClient.count throws an error', async () => { | ||
| const mockCountParams = { | ||
| index: 'example', | ||
| }; | ||
| const mockError = new Error('Count error'); | ||
| esClient.count.mockRejectedValueOnce(mockError); | ||
|
|
||
| await expect(uptimeEsClient.count(mockCountParams)).rejects.toThrow(mockError); | ||
| expect(esClient.count).toHaveBeenCalledWith(mockCountParams, { meta: true }); | ||
| }); | ||
| }); | ||
|
|
||
| describe('getInspectEnabled', () => { | ||
| it('should return false if uiSettings is not available', async () => { | ||
| const result = await uptimeEsClient.getInspectEnabled(); | ||
|
|
||
| expect(result).toBe(false); | ||
| }); | ||
|
|
||
| it('should return the value from uiSettings if available', async () => { | ||
| const mockUiSettings = uiSettingsServiceMock.createClient(); | ||
| uptimeEsClient.uiSettings = { | ||
| client: mockUiSettings, | ||
| } as any; | ||
|
|
||
| // @ts-expect-error | ||
| mockUiSettings.get.mockReturnValue(true); | ||
|
|
||
| await uptimeEsClient.getInspectEnabled(); | ||
|
|
||
| expect(uptimeEsClient.isInspectorEnabled).toBe(true); | ||
| expect(mockUiSettings.get).toHaveBeenCalledWith('observability:enableInspectEsQueries'); | ||
| }); | ||
| }); | ||
| describe('heartbeatIndices', () => { | ||
| it('appends synthetics-* in index for legacy alerts', async () => { | ||
| savedObjectsAdapter.getUptimeDynamicSettings = jest.fn().mockResolvedValue({ | ||
| heartbeatIndices: 'heartbeat-8*,heartbeat-7*', | ||
| syntheticsIndexRemoved: true, | ||
| }); | ||
| uptimeEsClient = new UptimeEsClient(savedObjectsClient, esClient, { isLegacyAlert: true }); | ||
|
|
||
| const mockSearchParams = { | ||
| body: { | ||
| query: { | ||
| match_all: {}, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| await uptimeEsClient.search({ | ||
| body: { | ||
| query: { | ||
| match_all: {}, | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| expect(esClient.search).toHaveBeenCalledWith( | ||
| { | ||
| index: 'heartbeat-8*,heartbeat-7*,synthetics-*', | ||
| ...mockSearchParams, | ||
| }, | ||
| { meta: true } | ||
| ); | ||
| }); | ||
| }); | ||
|
|
||
| // Add more tests for other methods and edge cases | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.