Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FieldFormatters] Human-readable duration inconsistent unit casing #101002

Closed
Dosant opened this issue May 31, 2021 · 3 comments · Fixed by #101479
Closed

[FieldFormatters] Human-readable duration inconsistent unit casing #101002

Dosant opened this issue May 31, 2021 · 3 comments · Fixed by #101479
Labels
bug Fixes for quality problems that affect the customer experience Feature:FieldFormatters good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@Dosant
Copy link
Contributor

Dosant commented May 31, 2021 •
edited
Loading

Kibana version: master (~7.14)

Description of the problem including expected versus actual behavior:

See Hours vs hours:

Screen Shot 2021-05-31 at 15 21 58

Steps to reproduce:
Use duration formatting with the human-readable format and with other options.

Additional context
Noticed while testing #100540 (review)
@Dosant Dosant added bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit loe:small Small Level of Effort Team:AppServices Feature:FieldFormatters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels May 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@d1v1b
Copy link
Contributor

d1v1b commented Jun 6, 2021

Hi, I made a change for this issue. And I made 2 changes for i18n in duration.

  1. I modified to show human-readable presice as lower cased.

スクリーンショット 2021-06-06 19 40 22

  1. I added some i18n sentences in duration.

スクリーンショット 2021-06-07 0 55 24

  1. I modified human-readable approximate to be shown with moment's i18n.

スクリーンショット 2021-06-07 0 55 03

Can I send a pull request for these 3 changes?

@Dosant
Copy link
Contributor Author

Dosant commented Jun 7, 2021

@d1v1b, go ahead 👍 will reivew

d1v1b added a commit to d1v1b/kibana that referenced this issue Jun 7, 2021
@d1v1b
[FieldFormatters] unify the Human-readable duration unit casing to lo…
f8bbbd8 
…wer cased (elastic#101002)
d1v1b added a commit to d1v1b/kibana that referenced this issue Jun 7, 2021
@d1v1b
[FieldFormatters] Add i18n for duration (elastic#101002)
b8a7e56
d1v1b added a commit to d1v1b/kibana that referenced this issue Jun 7, 2021
@d1v1b
[FieldFormatters] show units of human-readable approximate with momen…
17b5d48 
…t's i18n (elastic#101002)
@d1v1b d1v1b mentioned this issue Jun 7, 2021
Merged
3 tasks
d1v1b added a commit to d1v1b/kibana that referenced this issue Jun 7, 2021
@d1v1b
Revert "[FieldFormatters] Add i18n for duration (elastic#101002)"
feca1d2 
This reverts commit b8a7e56.
d1v1b added a commit to d1v1b/kibana that referenced this issue Jun 8, 2021
@d1v1b
Revert "[FieldFormatters] show units of human-readable approximate wi…
ee544d1 
…th moment's i18n (elastic#101002)"

This reverts commit 17b5d48.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:FieldFormatters good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FieldFormatters] Human-readable duration inconsistent unit casing d1v1b/kibana
3 participants
@Dosant @elasticmachine @d1v1b