Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAC] Populate workflow status fields for new lifecycle alerts #107650

Closed
weltenwort opened this issue Aug 4, 2021 · 4 comments · Fixed by #108215
Closed

[RAC] Populate workflow status fields for new lifecycle alerts #107650

weltenwort opened this issue Aug 4, 2021 · 4 comments · Fixed by #108215
Assignees
@afgomez
Labels
Feature:Observability RAC Feature:RAC label obsolete Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete v7.15.0

Comments

@weltenwort
Copy link
Member

weltenwort commented Aug 4, 2021 •
edited
Loading

📝 Summary

In order for the filters by workflow status to work in the UI, the related fields in the alert documents need to be populated when alerts fire for the first time. Later workflow status adjustments are explicitly performed by the user.

blocks #107629

✔️ Acceptance criteria

  • For new (meaning previously untracked) alerts the following fields are populated:
    • kibana.alert.workflow_status (via the constant ALERT_WORKFLOW_STATUS) contains 'open'
  • For existing (repeatedly firing) alerts the fields remain unchanged

❓ Questions

  • What should the workflow_reason code for newly firing alerts be? (new?)
    • We decided to leave it empty for now.
@weltenwort weltenwort added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete Feature:RAC label obsolete v7.15.0 needs-refinement A reason and acceptance criteria need to be defined for this issue Feature:Observability RAC labels Aug 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort mentioned this issue Aug 4, 2021
Closed
7 tasks
@jasonrhodes
Copy link
Member

Can we leave the workflow_reason empty for now? There is no way to update it as part of the "update workflow status" UI, I've just confirmed, so I'm hesitant to put anything here at all.

@jasonrhodes jasonrhodes mentioned this issue Aug 9, 2021
Closed
52 tasks
@weltenwort
Copy link
Member Author

Fine by me. I updated the ACs accordingly. Is this ready or do we require further refinement?

@jasonrhodes
Copy link
Member

All set!

@weltenwort weltenwort removed the needs-refinement A reason and acceptance criteria need to be defined for this issue label Aug 10, 2021
@jasonrhodes jasonrhodes mentioned this issue Aug 13, 2021
Merged
5 tasks
@weltenwort weltenwort mentioned this issue Aug 16, 2021
Closed
@mgiota mgiota mentioned this issue Aug 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afgomez afgomez

Labels
Feature:Observability RAC Feature:RAC label obsolete Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete v7.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RAC] Enable workflow status filtering afgomez/kibana
5 participants
@afgomez @jasonrhodes @weltenwort @elasticmachine @paulb-elastic