Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAC] Enable workflow status filtering #108215

Merged
merged 24 commits into from
Aug 20, 2021
Merged

[RAC] Enable workflow status filtering #108215

merged 24 commits into from
Aug 20, 2021

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Aug 11, 2021 •
edited by jasonrhodes
Loading

Closes #107629
Closes #107650

Summary

Implements the following items:

  • Move workflow status button group to left side above trend chart and change to sm, primary EuiButtonGroup
  • Workflow button group statuses should be Open, Acknowledged, Closed
  • Change "status" to "workflow status" to keep this clearly distinguished from "system status" (which is sometimes called "alert status" in the UI)
  • Sets each alert document's workflow status to "open"

The following item is not straightforward and will be implemented in a different PR

  • Move Last updated... to same line as button group and right align

@afgomez afgomez added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Feature:RAC label obsolete v7.15.0 labels Aug 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@afgomez afgomez mentioned this pull request Aug 11, 2021
Closed
7 tasks
@jasonrhodes
Copy link
Member

@elasticmachine merge upstream

@afgomez afgomez requested a review from a team as a code owner August 13, 2021 02:55
@afgomez afgomez requested review from a team August 13, 2021 02:55
@afgomez afgomez requested review from a team as code owners August 13, 2021 02:55
@afgomez afgomez requested a review from a team August 13, 2021 02:55
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Aug 13, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@jasonrhodes jasonrhodes force-pushed the 107629-workflow-status-filters branch 2 times, most recently from 39483a2 to 006f12c Compare August 13, 2021 04:13
@jasonrhodes jasonrhodes removed request for a team August 13, 2021 04:14
@mistic mistic added v7.16.0 and removed v7.15.0 labels Aug 18, 2021
semd
semd reviewed Aug 19, 2021
View reviewed changes
x-pack/plugins/timelines/common/types/timeline/actions/index.ts
/**
* @deprecated
* TODO: remove when `acknowledged` migrations are finished
*/
export type InProgressStatus = 'in-progress';

export type AlertStatus = 'open' | 'closed' | 'acknowledged' | InProgressStatus;
export type AlertStatus = AlertWorkflowStatus | InProgressStatus;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering why the in-progress status is still needed here. Shouldn't it be removed from security solutions too? @dplumlee

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've kept it since it was in master. I can remove it if necessary

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 490.0KB 489.6KB -404.0B
securitySolution 6.5MB 6.5MB -30.0B
total -434.0B
Unknown metric groups

API count

id before after diff
timelines 960 961 +1

API count missing comments

id before after diff
timelines 840 841 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

weltenwort
weltenwort approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, well done! 👏

x-pack/plugins/observability/public/pages/alerts/workflow_status_filter.tsx Show resolved Hide resolved
@afgomez afgomez enabled auto-merge (squash) August 19, 2021 21:05
@afgomez afgomez merged commit 5fd903b into elastic:master Aug 20, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.15 Commit could not be cherrypicked due to conflicts
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 108215

@weltenwort
Copy link
Member

The backports have failed to the lack of other backports:

I've updated or created the following to catch up:

@weltenwort weltenwort added auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Aug 20, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 20, 2021
@jasonrhodes @kibanamachine
[RAC] Enable workflow status filtering (elastic#108215)
50f72f5 
Co-authored-by: Jason Rhodes <jason.matthew.rhodes@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Aug 20, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
✅ 7.15
❌ 7.x Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 108215

@weltenwort
Copy link
Member

ℹ️ Backport failed because #109079 has not yet been merged, trying to fix...

kibanamachine added a commit that referenced this pull request Aug 20, 2021
@kibanamachine @jasonrhodes
[RAC] Enable workflow status filtering (#108215) (#109453)
37a2423 
Co-authored-by: Jason Rhodes <jason.matthew.rhodes@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Alejandro Fernández Gómez <alejandro.fernandez@elastic.co>
Co-authored-by: Jason Rhodes <jason.matthew.rhodes@gmail.com>
@weltenwort weltenwort mentioned this pull request Aug 20, 2021
Closed
weltenwort pushed a commit to weltenwort/kibana that referenced this pull request Aug 20, 2021
@jasonrhodes @kibanamachine @weltenwort
[RAC] Enable workflow status filtering (elastic#108215)
c737792 
Co-authored-by: Jason Rhodes <jason.matthew.rhodes@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@afgomez afgomez mentioned this pull request Aug 24, 2021
Merged
afgomez pushed a commit to afgomez/kibana that referenced this pull request Aug 24, 2021
[RAC] Enable workflow status filtering (elastic#108215)
02eae41 
Co-authored-by: Jason Rhodes <jason.matthew.rhodes@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid.tsx
#	x-pack/plugins/observability/public/pages/alerts/index.tsx
afgomez pushed a commit that referenced this pull request Aug 24, 2021
@kibanamachine
[7.x] [RAC] Enable workflow status filtering (#108215) (#109817)
e638552 
* [RAC] Enable workflow status filtering (#108215)

Co-authored-by: Jason Rhodes <jason.matthew.rhodes@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid.tsx
#	x-pack/plugins/observability/public/pages/alerts/index.tsx

* Backport changes in the tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@mgiota mgiota mentioned this pull request Nov 29, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

@semd semd semd left review comments

@jasonrhodes jasonrhodes jasonrhodes left review comments

@mdefazio mdefazio mdefazio approved these changes

@weltenwort weltenwort weltenwort approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:RAC label obsolete release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
10 participants
@afgomez @elasticmachine @jasonrhodes @mdefazio @kibanamachine @weltenwort @dgieselaar @semd @kqualters-elastic @mistic