Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Page is flickering when click on show top modal of Max anomaly score by job under Alerts Page #133186

Closed
ghost opened this issue May 31, 2022 · 4 comments · Fixed by #139079
Closed

[Security Solution] Page is flickering when click on show top modal of Max anomaly score by job under Alerts Page #133186

ghost opened this issue May 31, 2022 · 4 comments · Fixed by #139079
Assignees
@logeekal
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.5.0

Comments

@ghost
Copy link

ghost commented May 31, 2022

Describe the bug
Page is flickering when click on show top modal of Max anomaly score by job under Alerts Page

Build info

Version: 8.3.0 SNAPSHOT
Build: 53035
Commit: c993ff2a4fa10898d5a6e15aeb1d0848534ae48e

preconditions

  1. Kibana should be up and running
  2. Alerts should be triggered with ML anomaly score

Steps to Reproduce

  1. Navigate to Alerts page under security
  2. Click on host name details under host.name column of above generated alert
  3. Click on ML Anomaly score show top hover action
  4. Observe that page is flickering when click on show top modal of Max anomaly score by job under Alerts Page

Actual Result
Page is flickering when click on show top modal of Max anomaly score by job under Alerts Page

Expected Result
Page should not be flicker when click on show top modal of Max anomaly score by job under Alerts Page

Screenshot

show.top.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels May 31, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost assigned ghost and MadameSheema and unassigned ghost May 31, 2022
@MadameSheema MadameSheema added Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team labels Jun 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@michaelolo24 michaelolo24 removed their assignment Jun 2, 2022
@logeekal logeekal self-assigned this Aug 12, 2022
@logeekal logeekal linked a pull request Aug 18, 2022 that will close this issue
[Security Solution] Fixes the position of popover when presenting dynamic content #139079
Merged
1 task
@logeekal logeekal mentioned this issue Aug 18, 2022
Merged
1 task
logeekal added a commit that referenced this issue Aug 25, 2022
@logeekal
[Security Solution] Fixes the position of popover when presenting dyn…
acf675c 
…amic content (#139079)

## Summary

Issue #133186 ( as shown in below video) demonstrates couple of issues and this PR tries to fix those.

https://user-images.githubusercontent.com/61860752/171141631-f633a223-af76-457d-bed2-6bd8ea418a0e.mp4

**ISSUE - 1**

When in host details flyout, clicking on `show Top N`, the datagrid will flicker scrolling from right to left and then back to its original position.

**Solution** : This issue was not reproducible so I am assuming this has been already resolved. ( See below video for more details)

 
**ISSUE - 2**

When in host details flyout, clicking on `show Top N`, the popup hides behind the bottom screen edge. This is because initially the popup was small but when `Show TopN` is clicked, the content of Popup is changed and popup becomes bigger in size forcing it to exceed out of the screen's real estate.

**Solution** : This PR makes sure that, if hover actions Popup's content changes, Popup is re-positioned according to its new dimensions. Checkout below demonstration.


https://user-images.githubusercontent.com/7485038/185380538-d8fb159a-d666-4be2-b3b0-161a21d1b9d6.mov
@ghost ghost added the fixed label Aug 25, 2022
@ghost ghost reopened this Aug 25, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 25, 2022
@logeekal
[Security Solution] Fixes the position of popover when presenting dyn…
842cb3b 
…amic content (elastic#139079)

## Summary

Issue elastic#133186 ( as shown in below video) demonstrates couple of issues and this PR tries to fix those.

https://user-images.githubusercontent.com/61860752/171141631-f633a223-af76-457d-bed2-6bd8ea418a0e.mp4

**ISSUE - 1**

When in host details flyout, clicking on `show Top N`, the datagrid will flicker scrolling from right to left and then back to its original position.

**Solution** : This issue was not reproducible so I am assuming this has been already resolved. ( See below video for more details)

**ISSUE - 2**

When in host details flyout, clicking on `show Top N`, the popup hides behind the bottom screen edge. This is because initially the popup was small but when `Show TopN` is clicked, the content of Popup is changed and popup becomes bigger in size forcing it to exceed out of the screen's real estate.

**Solution** : This PR makes sure that, if hover actions Popup's content changes, Popup is re-positioned according to its new dimensions. Checkout below demonstration.

https://user-images.githubusercontent.com/7485038/185380538-d8fb159a-d666-4be2-b3b0-161a21d1b9d6.mov
(cherry picked from commit acf675c)
kibanamachine added a commit that referenced this issue Aug 25, 2022
@kibanamachine @logeekal
[Security Solution] Fixes the position of popover when presenting dyn…
6f7ac5a 
…amic content (#139079) (#139454)

## Summary

Issue #133186 ( as shown in below video) demonstrates couple of issues and this PR tries to fix those.

https://user-images.githubusercontent.com/61860752/171141631-f633a223-af76-457d-bed2-6bd8ea418a0e.mp4

**ISSUE - 1**

When in host details flyout, clicking on `show Top N`, the datagrid will flicker scrolling from right to left and then back to its original position.

**Solution** : This issue was not reproducible so I am assuming this has been already resolved. ( See below video for more details)

**ISSUE - 2**

When in host details flyout, clicking on `show Top N`, the popup hides behind the bottom screen edge. This is because initially the popup was small but when `Show TopN` is clicked, the content of Popup is changed and popup becomes bigger in size forcing it to exceed out of the screen's real estate.

**Solution** : This PR makes sure that, if hover actions Popup's content changes, Popup is re-positioned according to its new dimensions. Checkout below demonstration.

https://user-images.githubusercontent.com/7485038/185380538-d8fb159a-d666-4be2-b3b0-161a21d1b9d6.mov
(cherry picked from commit acf675c)

Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
@ghost
Copy link
Author

ghost commented Aug 30, 2022

Hi Team,

We have validated this issue on 8.5.0 SNAPSHOT build and observed that issue is Fixed. .

Please find the below Testing Details:

Build info

Version:8.5.0 snapshot
BUILD: 55843
COMMIT: 316b1a0e894086e2cfad7f1828f3856e0d2433bd

Screen-cast

Alerts.mp4

Hence, We are closing this issue and marking as QA Validated!!

Thanks!!

@ghost ghost added the QA:Validated Issue has been validated by QA label Aug 30, 2022
@ghost ghost closed this as completed Aug 30, 2022
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this issue Sep 6, 2022
@logeekal @Mpdreamz
[Security Solution] Fixes the position of popover when presenting dyn…
45951f2 
…amic content (elastic#139079)

## Summary

Issue elastic#133186 ( as shown in below video) demonstrates couple of issues and this PR tries to fix those.

https://user-images.githubusercontent.com/61860752/171141631-f633a223-af76-457d-bed2-6bd8ea418a0e.mp4

**ISSUE - 1**

When in host details flyout, clicking on `show Top N`, the datagrid will flicker scrolling from right to left and then back to its original position.

**Solution** : This issue was not reproducible so I am assuming this has been already resolved. ( See below video for more details)

 
**ISSUE - 2**

When in host details flyout, clicking on `show Top N`, the popup hides behind the bottom screen edge. This is because initially the popup was small but when `Show TopN` is clicked, the content of Popup is changed and popup becomes bigger in size forcing it to exceed out of the screen's real estate.

**Solution** : This PR makes sure that, if hover actions Popup's content changes, Popup is re-positioned according to its new dimensions. Checkout below demonstration.


https://user-images.githubusercontent.com/7485038/185380538-d8fb159a-d666-4be2-b3b0-161a21d1b9d6.mov
@ghost
Copy link
Author

ghost commented Sep 23, 2022 •
edited by ghost
Loading

Hi Team

We have validated this issue on 8.5.0-BC1 build and observed that the issue is fixed.

Please find below the testing details:

Build Details:

VERSION: 8.5.0-BC1
COMMIT: 0d8de4df69f8084a94cdd9638d7de510813cb5ce
BUILD: 56595

Screen-Recording:

ml.mp4

cc: @MadameSheema
Thanks!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@logeekal logeekal

Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] Fixes the position of popover when presenting dynamic content logeekal/kibana
4 participants
@logeekal @elasticmachine @michaelolo24 @MadameSheema