Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Edit rule button is enable to ML rule on basic license #139796

Closed
ghost opened this issue Aug 31, 2022 · 10 comments
Closed

[Security Solution] Edit rule button is enable to ML rule on basic license #139796

ghost opened this issue Aug 31, 2022 · 10 comments
Assignees
@maximpn
Labels
8.6 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Details Security Solution Detection Rule Details page fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.5.1 v8.6.0

Comments

@ghost
Copy link

ghost commented Aug 31, 2022

Describe the bug
Edit rule button is enable to ML rule on basic license

Build info

VERSION : 8.5.0 SNAPSHOT
BUILD: 55843
COMMIT: 316b1a0e894086e2cfad7f1828f3856e0d2433bd

Preconditions

  1. Kibana should be running
  2. ML rule should be created

Steps to Reproduce

  1. Navigate to security > Rules page
  2. Navigate to ML rule details page
  3. Observe that Rule enable/disable toggle is not grey out
  4. Observe that Edit rule button is enable to ML rule on basic license

Actual Result
Edit rule button is enable to ML rule on basic license

Expected Result
Edit rule button and Rule enable/disable toggle should be grey out for ML rule on basic license

Screen-cast

ml.mp4

What's Working

  • User is not able to edit the ML rule and unable to enable/disable rule
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Aug 31, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v8.5.0 labels Aug 31, 2022
@ghost ghost assigned ghost and banderror and unassigned ghost Aug 31, 2022
@MadameSheema MadameSheema added Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team labels Sep 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror banderror added Feature:Rule Details Security Solution Detection Rule Details page and removed triage_needed v8.5.0 labels Sep 6, 2022
@banderror banderror removed their assignment Sep 6, 2022
@maximpn maximpn self-assigned this Oct 12, 2022
@maximpn maximpn mentioned this issue Oct 13, 2022
Merged
4 tasks
@maximpn maximpn mentioned this issue Oct 21, 2022
Open
maximpn added a commit that referenced this issue Oct 21, 2022
@maximpn
[Security Solution] Disable ML rule's edit button link under basic li…
a670c7f 
…cense (#143260)

**Resolves:** [#139796](#139796)

## Summary

It disables ML rule's edit button link under the basic license.

## Details

ML rules aren't available under the basic license but installable from the prebuilt rules. Having an active edit button makes the UX inconsistent. Disabling such a button under the basic license for ML rules improves UX though doesn't block a user from opening the rule editing page from the address bar.


Before:

https://user-images.githubusercontent.com/3775283/195552179-525f0423-3a62-4ab5-b1ef-0f5cafe2286e.mov

After:

https://user-images.githubusercontent.com/3775283/195551540-b95fabeb-4e50-4a26-ae42-1a72f53573dc.mov


### Checklist

- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
@banderror
Copy link
Contributor

@deepikakeshav-qasource fixed in #143260

@ghost
Copy link
Author

ghost commented Oct 31, 2022

Hi Team,

We have validated this issue on 8.6.0 SNAPSHOT build and Observed that issue is Fixed. 🟢

Please find the below details:

Version: 8.6.0 SNAPSHOT
BUILD: 57808
COMMIT: 796751e2d3f36499cb8eb61b436c03006632f1ef

Screencast:

ML.rule.mp4

Hence, we closing this issue and marking as QA Validated!!

Thanks!!

@ghost ghost added the QA:Validated Issue has been validated by QA label Oct 31, 2022
@ghost ghost closed this as completed Oct 31, 2022
@banderror
Copy link
Contributor

@deepikakeshav-qasource We'll backport the fix to the 8.5 branch soon after Elastic releases 8.5.0, so the fix will be released in 8.5.1 as well. Not sure if you'd like to keep this ticket closed or open in this case.

@ghost
Copy link
Author

ghost commented Oct 31, 2022

Thanks for the update @banderror .

Sure, we are opening this ticket to regress this issue on 8.5.1 as well.

@ghost ghost reopened this Oct 31, 2022
@banderror
Copy link
Contributor

@deepikakeshav-qasource Perfect, thank you!

@maximpn Please backport the fix to the 8.5 branch soon after Elastic releases 8.5.0. Thanks!

maximpn added a commit to maximpn/kibana that referenced this issue Nov 7, 2022
@maximpn
[Security Solution] Disable ML rule's edit button link under basic li…
355454c 
…cense (elastic#143260)

**Resolves:** [elastic#139796](elastic#139796)

## Summary

It disables ML rule's edit button link under the basic license.

## Details

ML rules aren't available under the basic license but installable from the prebuilt rules. Having an active edit button makes the UX inconsistent. Disabling such a button under the basic license for ML rules improves UX though doesn't block a user from opening the rule editing page from the address bar.

Before:

https://user-images.githubusercontent.com/3775283/195552179-525f0423-3a62-4ab5-b1ef-0f5cafe2286e.mov

After:

https://user-images.githubusercontent.com/3775283/195551540-b95fabeb-4e50-4a26-ae42-1a72f53573dc.mov

### Checklist

- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

(cherry picked from commit a670c7f)

# Conflicts:
#	x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/details/index.tsx
maximpn added a commit that referenced this issue Nov 7, 2022
@maximpn
[Security Solution] Disable ML rule's edit button link under basic li…
adf0740 
…cense (#143260) (#144723)

**Resolves:** [#139796](#139796)

## Summary

It disables ML rule's edit button link under the basic license.

## Details

ML rules aren't available under the basic license but installable from the prebuilt rules. Having an active edit button makes the UX inconsistent. Disabling such a button under the basic license for ML rules improves UX though doesn't block a user from opening the rule editing page from the address bar.

Before:

https://user-images.githubusercontent.com/3775283/195552179-525f0423-3a62-4ab5-b1ef-0f5cafe2286e.mov

After:

https://user-images.githubusercontent.com/3775283/195551540-b95fabeb-4e50-4a26-ae42-1a72f53573dc.mov

### Checklist

- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

(cherry picked from commit a670c7f)

# Conflicts:
#	x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/details/index.tsx
@maximpn
Copy link
Contributor

maximpn commented Nov 7, 2022 •
edited
Loading

@deepikakeshav-qasource @banderror The fix has been backported to 8.5.1.

@ghost
Copy link
Author

ghost commented Nov 10, 2022 •
edited by ghost
Loading

Hi Team,

We have validated this issue on 8.5.1 BC1 and found the issue is fixed now. ✔️

Build Details:

Version: 8.5.1 BC1
Commit:87149bfd06f4fe41dbfa7e95461294e9dadfb1d8
Build:57136

Screen-Shot:

image

image

Hence we are closing this issue.

Thanks !!!

@ghost ghost closed this as completed Nov 10, 2022
@ghost
Copy link
Author

ghost commented Nov 17, 2022

Hi Team ,

We have validated this issue on 8.6.0 BC1 build and Observe that issue is Fixed

Please find the below details:

Version: 8.6.0 BC1
BUILD: 58392
COMMIT: 50a7feb0a5eb068d3acccc49c83b9ccb6db6734f

Screenshot:

image

Thanks!!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximpn maximpn

Labels
8.6 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Details Security Solution Detection Rule Details page fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.5.1 v8.6.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maximpn @banderror @elasticmachine @MadameSheema