-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rule tags in Alert Details page to match with the design #141674
Labels
Team: Actionable Observability - DEPRECATED
For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
v8.6.0
Comments
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
Closed
3 tasks
17 tasks
1 task
benakansara
added a commit
that referenced
this issue
Nov 23, 2022
## Summary Closes #141674 Styling of rule tags changed and some other minor style changes in Alert summary component of Alert details page. <img width="1723" alt="Screenshot 2022-11-22 at 18 59 14" src="https://user-images.githubusercontent.com/69037875/203387567-f4b7e89e-f075-4c2a-84fc-ac477cf5ba63.png"> <img width="1724" alt="Screenshot 2022-11-22 at 18 57 24" src="https://user-images.githubusercontent.com/69037875/203387362-2cd7c549-09e2-4772-8de9-33aebfd6d428.png"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: shahzad31 <shahzad.muhammad@elastic.co>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 23, 2022
## Summary Closes elastic#141674 Styling of rule tags changed and some other minor style changes in Alert summary component of Alert details page. <img width="1723" alt="Screenshot 2022-11-22 at 18 59 14" src="https://user-images.githubusercontent.com/69037875/203387567-f4b7e89e-f075-4c2a-84fc-ac477cf5ba63.png"> <img width="1724" alt="Screenshot 2022-11-22 at 18 57 24" src="https://user-images.githubusercontent.com/69037875/203387362-2cd7c549-09e2-4772-8de9-33aebfd6d428.png"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: shahzad31 <shahzad.muhammad@elastic.co> (cherry picked from commit 3e7d3ec)
kibanamachine
referenced
this issue
Nov 23, 2022
) # Backport This will backport the following commits from `main` to `8.6`: - [Change style of rule tags in alert details page (#145946)](#145946) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bena Kansara","email":"69037875+benakansara@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-11-23T10:01:29Z","message":"Change style of rule tags in alert details page (#145946)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/141674\r\n\r\nStyling of rule tags changed and some other minor style changes in Alert\r\nsummary component of Alert details page.\r\n\r\n<img width=\"1723\" alt=\"Screenshot 2022-11-22 at 18 59 14\"\r\nsrc=\"https://user-images.githubusercontent.com/69037875/203387567-f4b7e89e-f075-4c2a-84fc-ac477cf5ba63.png\">\r\n\r\n\r\n<img width=\"1724\" alt=\"Screenshot 2022-11-22 at 18 57 24\"\r\nsrc=\"https://user-images.githubusercontent.com/69037875/203387362-2cd7c549-09e2-4772-8de9-33aebfd6d428.png\">\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: shahzad31 <shahzad.muhammad@elastic.co>","sha":"3e7d3ec2598821d034f18e13a343ec3dc994a5bc","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: Actionable Observability","backport:prev-minor","v8.6.0","v8.7.0"],"number":145946,"url":"https://github.com/elastic/kibana/pull/145946","mergeCommit":{"message":"Change style of rule tags in alert details page (#145946)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/141674\r\n\r\nStyling of rule tags changed and some other minor style changes in Alert\r\nsummary component of Alert details page.\r\n\r\n<img width=\"1723\" alt=\"Screenshot 2022-11-22 at 18 59 14\"\r\nsrc=\"https://user-images.githubusercontent.com/69037875/203387567-f4b7e89e-f075-4c2a-84fc-ac477cf5ba63.png\">\r\n\r\n\r\n<img width=\"1724\" alt=\"Screenshot 2022-11-22 at 18 57 24\"\r\nsrc=\"https://user-images.githubusercontent.com/69037875/203387362-2cd7c549-09e2-4772-8de9-33aebfd6d428.png\">\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: shahzad31 <shahzad.muhammad@elastic.co>","sha":"3e7d3ec2598821d034f18e13a343ec3dc994a5bc"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145946","number":145946,"mergeCommit":{"message":"Change style of rule tags in alert details page (#145946)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/141674\r\n\r\nStyling of rule tags changed and some other minor style changes in Alert\r\nsummary component of Alert details page.\r\n\r\n<img width=\"1723\" alt=\"Screenshot 2022-11-22 at 18 59 14\"\r\nsrc=\"https://user-images.githubusercontent.com/69037875/203387567-f4b7e89e-f075-4c2a-84fc-ac477cf5ba63.png\">\r\n\r\n\r\n<img width=\"1724\" alt=\"Screenshot 2022-11-22 at 18 57 24\"\r\nsrc=\"https://user-images.githubusercontent.com/69037875/203387362-2cd7c549-09e2-4772-8de9-33aebfd6d428.png\">\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: shahzad31 <shahzad.muhammad@elastic.co>","sha":"3e7d3ec2598821d034f18e13a343ec3dc994a5bc"}}]}] BACKPORT--> Co-authored-by: Bena Kansara <69037875+benakansara@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team: Actionable Observability - DEPRECATED
For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
v8.6.0
Part of #138645
Make "Rule Tags" match with design. Show "-" when there are no tags available.
The text was updated successfully, but these errors were encountered: