Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Actionable Observability] - Create alertDetailAppSection for the APM Alert Details page #143183

Closed
Tracked by #138645
fkanout opened this issue Oct 12, 2022 · 2 comments · Fixed by #143298
Closed
Tracked by #138645

[Actionable Observability] - Create alertDetailAppSection for the APM Alert Details page #143183

fkanout opened this issue Oct 12, 2022 · 2 comments · Fixed by #143298
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0

Comments

@fkanout
Copy link
Contributor

fkanout commented Oct 12, 2022 •
edited
Loading

📝 Summary

Part of #138645
Related to #139401
According to the RFC
Design Figma file

Based on the PoC PR we need to create alertDetailAppSection, which is a lazy component that lives under the APM plugin folder. It contains all required charts for the APM rule types.

✅ AC

  • The initialization of alertDetailAppSection should be done during the rules creating
  • alertDetailAppSection component is going to be accessible from the ruleTypeModel
  • alertDetailAppSection component will accept the following props alert, rule
  • These props need to be passed to the charts that are hosted under the alertDetailAppSection component
  • The current APM charts are not exposing all the previous listed props, so updating the chart is required in this case
@fkanout fkanout added backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0 labels Oct 12, 2022
@fkanout fkanout self-assigned this Oct 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@fkanout fkanout removed backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes labels Oct 12, 2022
This was referenced Oct 12, 2022
Closed
Merged
@fkanout fkanout mentioned this issue Nov 17, 2022
Closed
@fkanout fkanout added v8.7.0 and removed v8.6.0 labels Nov 28, 2022
fkanout added a commit that referenced this issue Dec 1, 2022
@fkanout
[Actionable Observability] - add alertDetailAppSection to the APM Rul…
137d178 
…e Details page (#143298)

## Summary

It fixes #145572 and #143183 by
- Adding an abstraction layer for the Timeseries chart and using it
without APM's context and hooks
- Create and link `AlertDetailAppSection` new component to all APM rule
types
- Provide the new Alert Details page under Observability using APM
charts

<img width="1205" alt="Screenshot 2022-11-08 at 17 22 17"
src="https://user-images.githubusercontent.com/6838659/200619684-0f9eaf5b-4618-4dd3-8539-f4bc13107c2e.png">

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)


## For the reviewers
- Enable the feature flag
`xpack.observability.unsafe.alertDetails.apm.enabled: true` in
`kibana.yml`.
- Create an APM rule that fires alerts
- Click on `View alert details` from the Alert table
@fkanout
Copy link
Contributor Author

fkanout commented Dec 2, 2022

Done with #143298

@fkanout fkanout closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Actionable Observability] - add alertDetailAppSection to the APM Rule Details page fkanout/kibana
2 participants
@fkanout @elasticmachine