Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Monitor details page - renders incorrectly when a monitor does not exist #144366

Closed
dominiqueclarke opened this issue Nov 1, 2022 · 3 comments · Fixed by #145569 or #149924
Closed

[Synthetics] Monitor details page - renders incorrectly when a monitor does not exist #144366

dominiqueclarke opened this issue Nov 1, 2022 · 3 comments · Fixed by #145569 or #149924
Assignees
@dominiqueclarke
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.0

Comments

@dominiqueclarke
Copy link
Contributor

dominiqueclarke commented Nov 1, 2022 •
edited
Loading

Synthetics monitor details will attempt to render in a broken state when the monitor doesn't exist. Instead, we should show appropriate UX when a monitor does not exist.

Screen Shot 2022-11-01 at 4 40 47 PM

Steps to reproduce:

  1. Create a monitor
  2. Navigate to that monitor's detail page
  3. In a separate window, delete that monitor
  4. Refresh the monitor details page
  5. Observe broken experience
@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0 labels Nov 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@afgomez afgomez self-assigned this Nov 17, 2022
@afgomez afgomez mentioned this issue Nov 17, 2022
Merged
afgomez pushed a commit that referenced this issue Dec 6, 2022
@kibanamachine
[Synthetics UI] Render a 404 error if a monitor doesn't exist (#145569)
00df93e 
## Summary

Closes #144366.

This PR needs to wait for #145598
to use a shared `<NotFound />` component instead of creating its own.

### How to test
- Visit a monitor page with a bogus ID, like
`http://<kibana-base-path>/app/synthetics/monitor/i-dont-exist`

Before:

<img width="1276" alt="Screenshot 2022-11-17 at 15 07 51"
src="https://user-images.githubusercontent.com/57448/202469421-3d065d43-740d-4878-9a64-504c711ddcf9.png">


After:

<img width="1279" alt="Screenshot 2022-11-17 at 15 06 38"
src="https://user-images.githubusercontent.com/57448/202469433-6a6d22e3-8b1a-48f1-9934-f5094b89bac1.png">

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@afgomez
Copy link
Contributor

afgomez commented Dec 16, 2022

Reopening due to #147694

@afgomez afgomez reopened this Dec 16, 2022
@shahzad31 shahzad31 assigned shahzad31 and unassigned afgomez Jan 31, 2023
@shahzad31 shahzad31 mentioned this issue Jan 31, 2023
Merged
shahzad31 added a commit that referenced this issue Jan 31, 2023
@shahzad31
[Synthetics] Added monitor not found page (#149924)
3e5b1e4 
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Fixes #144366
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this issue Feb 6, 2023
@shahzad31 @kqualters-elastic
[Synthetics] Added monitor not found page (elastic#149924)
0ab7722 
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Fixes elastic#144366
@dominiqueclarke dominiqueclarke self-assigned this Feb 8, 2023
@dominiqueclarke
Copy link
Contributor Author

Post FF testing: 404 page is rendering correctly and links work.

Screen Shot 2023-02-08 at 10 12 45 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominiqueclarke dominiqueclarke

Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.0
Projects
None yet
Milestone
No milestone
4 participants
@afgomez @shahzad31 @dominiqueclarke @elasticmachine