[Synthetics UI] Render a 404 error if a monitor doesn't exist #145569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
afgomez
added
release_note:skip
dominiqueclarke
approved these changes
Nov 21, 2022
afgomez
commented
Dec 2, 2022
Comment on lines
+56
to
+62
| if (colorMode === 'DARK') { | ||
| const { default: imgSrc } = await import(`./assets/404_astronaut_dark.png`); | ||
| setImageSrc(imgSrc); | ||
| } else { | ||
| const { default: imgSrc } = await import(`./assets/404_astronaut_light.png`); | ||
| setImageSrc(imgSrc); | ||
| } |
There was a problem hiding this comment.
@elastic/kibana-global-experience Kibana's optimizer needs static paths in all import statements so I need to deduplicate this.
majagrubic
approved these changes
Dec 2, 2022
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsasync chunk count
ESLint disabled in files
ESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #144366.
This PR needs to wait for #145598 to use a shared
<NotFound />component instead of creating its own.How to test
http://<kibana-base-path>/app/synthetics/monitor/i-dont-existBefore:
After: