-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics UI] Render a 404 error if a monitor doesn't exist #145569
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
deda8b3
Expose errors in selected monitor hook
5545466
Skip monitor breadcrumb if it's not present
ad2d8b6
Render 404 error if monitor ID does not exist
d5c6eec
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine e2f04f5
Merge branch 'main' into 145515-monitor-404-page
a1345ae
Merge branch 'main' into 145515-monitor-404-page
29b5b2f
Use static paths for the 404 assets
dda4272
Use the shared 404 prompt
8d6ecdd
Merge branch 'main' into 145515-monitor-404-page
d031ff3
Merge branch 'main' into 145515-monitor-404-page
shahzad31 3c1eab4
Only refetch if there is an ID
37b4d2b
Merge branch 'main' into 145515-monitor-404-page
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
x-pack/plugins/synthetics/public/apps/synthetics/components/not_found/not_found.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import React from 'react'; | ||
import { EuiEmptyPrompt } from '@elastic/eui'; | ||
import { i18n } from '@kbn/i18n'; | ||
|
||
const NOT_FOUND_TITLE = i18n.translate('xpack.synthetics.notFoundTitle', { | ||
defaultMessage: 'Page not found', | ||
}); | ||
|
||
const NOT_FOUND_BODY = i18n.translate('xpack.synthetics.notFoundBody', { | ||
defaultMessage: | ||
"Sorry, we can't find the page you're looking for. It might have been removed or renamed, or maybe it never existed.", | ||
}); | ||
|
||
/** | ||
* Renders a "Page not found" error. | ||
* | ||
* @deprecated This component must be moved to Kibana/Shared UX. It was created | ||
* as a temporary solution to move #144366 forward but it should not be used. | ||
*/ | ||
export function NotFound(): JSX.Element { | ||
return ( | ||
<EuiEmptyPrompt | ||
layout="vertical" | ||
color="subdued" | ||
titleSize="m" | ||
iconType="questionInCircle" | ||
iconColor="primary" | ||
title={<h2>{NOT_FOUND_TITLE}</h2>} | ||
body={<p>{NOT_FOUND_BODY}</p>} | ||
/> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elastic/kibana-global-experience Kibana's optimizer needs static paths in all import statements so I need to deduplicate this.