Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Link to maximized panel #145454

Closed
Tracked by #149155
cqliu1 opened this issue Nov 16, 2022 · 7 comments · Fixed by #190086
Closed
Tracked by #149155

[Dashboard] Link to maximized panel #145454

cqliu1 opened this issue Nov 16, 2022 · 7 comments · Fixed by #190086
Assignees
@rshen91
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Dashboard Usability Related to the Dashboard Usability initiative regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@cqliu1
Copy link
Contributor

cqliu1 commented Nov 16, 2022 •
edited
Loading

Related to #141547.

We should provide a way to jump to a specific panel on a dashboard. When a user is maximized on a panel and wants to share it with another user, the URL should contain the ID of the maximized panel and when pasted, the URL will direct you to the maximized version of the panel in that dashboard.
@cqliu1 cqliu1 added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:large Large Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Project:Dashboard Usability Related to the Dashboard Usability initiative labels Nov 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@cqliu1 cqliu1 mentioned this issue Nov 16, 2022
Closed
22 tasks
@cqliu1 cqliu1 changed the title [Dashboard] Jump to/scroll to panel [Dashboard] Link to maximized panel Jan 13, 2023
@cqliu1 cqliu1 mentioned this issue Jan 18, 2023
Closed
18 tasks
@ThomThomson ThomThomson mentioned this issue Feb 6, 2023
Closed
@ThomThomson ThomThomson mentioned this issue Feb 23, 2023
Closed
@ThomThomson
Copy link
Contributor

ThomThomson commented May 31, 2023 •
edited
Loading

Noting here that this is actually a regression, because the expandedPanelId used to be part of the Input and would therefore get included in the snapshot shared URLs which would allow users to deep link to one panel.

Bumping this one to impact:high

@ThomThomson ThomThomson added regression impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels May 31, 2023
@ThomThomson ThomThomson mentioned this issue May 31, 2023
Closed
@tomhe
Copy link

tomhe commented Sep 22, 2023

We have lots of users asking for this feature to return and I'd like to give them some hope. :-)

Is there a plan for fixing this regression any time soon?

@ThomThomson
Copy link
Contributor

@tomhe we haven't prioritized this issue yet as there are more pressing problems. As a workaround, have you tried linking directly to the panel from its editor? For instance if it's a Lens panel, you can share from the Lens interface.

@tomhe
Copy link

tomhe commented Sep 22, 2023

@ThomThomson, the share feature from inside the Lens panel creates a snapshot link that redirects to the full edit view of the panel. Our use case is mainly to embed a panel in another service, like Confluence or a custom web page as an iframe.

Your suggestion would work fine for us if there was an option to hide the edit UI (left and right of panel, search box, filter bar).

@IanLee1521
Copy link

One of the other drawbacks to using the link into the Lens directly is that I believe you lose some understanding of what dashboard that visualization might be embedded in dashboard wise.

As for the overall goal of bringing this back, I'm definitely for. For my understanding, would this mean that when the dashboard loads with the panel maximized, other panels wouldn't necessarily be triggered for load until I came out of maximize?

@cqliu1
Copy link
Contributor Author

cqliu1 commented Mar 14, 2024 •
edited
Loading

Closing this and adding to our icebox. We're unable to prioritize this feature in the near future, but we'll keep tracking this here #154667.

We've decided to prioritize this feature in the near term.

@cqliu1 cqliu1 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 14, 2024
@cqliu1 cqliu1 mentioned this issue Mar 14, 2024
Open
@ThomThomson ThomThomson reopened this Apr 24, 2024
@rshen91 rshen91 self-assigned this Jul 30, 2024
This was referenced Aug 1, 2024
Closed
Merged
@Heenawter Heenawter removed the loe:large Large Level of Effort label Aug 15, 2024
@Heenawter Heenawter added the loe:medium Medium Level of Effort label Aug 15, 2024
@teresaalvarezsoler teresaalvarezsoler added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Aug 29, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 19, 2024
@rshen91
[Dashboard] Sharing via link to an expanded panel (elastic#190086)
3a3318d 
## Summary

Closes elastic#145454

This PR allows users with a dashboard with an expanded (maximized) panel
to be shared to other users via url or the share modal link. To
implement this, the expanded panel Id is added to the url:

`/app/dashboard/{dashboardID}/{expandedPanelID}_g()_a()`

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Hannah Mudge <hannah.wright@elastic.co>
(cherry picked from commit 6030231)
kibanamachine referenced this issue Sep 19, 2024
@kibanamachine @rshen91
[8.x] [Dashboard] Sharing via link to an expanded panel (#190086) (#1…
331de8d 
…93458)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Dashboard] Sharing via link to an expanded panel
(#190086)](#190086)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rachel
Shen","email":"rshen@elastic.co"},"sourceCommit":{"committedDate":"2024-09-19T17:38:21Z","message":"[Dashboard]
Sharing via link to an expanded panel (#190086)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/145454\r\n\r\nThis PR allows
users with a dashboard with an expanded (maximized) panel\r\nto be
shared to other users via url or the share modal link. To\r\nimplement
this, the expanded panel Id is added to the
url:\r\n\r\n`/app/dashboard/{dashboardID}/{expandedPanelID}_g()_a()`\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Hannah Mudge
<hannah.wright@elastic.co>","sha":"603023124681429ee900ff3a73793ce31a9cad58","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","loe:medium","impact:medium","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Dashboard]
Sharing via link to an expanded
panel","number":190086,"url":"https://github.com/elastic/kibana/pull/190086","mergeCommit":{"message":"[Dashboard]
Sharing via link to an expanded panel (#190086)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/145454\r\n\r\nThis PR allows
users with a dashboard with an expanded (maximized) panel\r\nto be
shared to other users via url or the share modal link. To\r\nimplement
this, the expanded panel Id is added to the
url:\r\n\r\n`/app/dashboard/{dashboardID}/{expandedPanelID}_g()_a()`\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Hannah Mudge
<hannah.wright@elastic.co>","sha":"603023124681429ee900ff3a73793ce31a9cad58"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190086","number":190086,"mergeCommit":{"message":"[Dashboard]
Sharing via link to an expanded panel (#190086)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/145454\r\n\r\nThis PR allows
users with a dashboard with an expanded (maximized) panel\r\nto be
shared to other users via url or the share modal link. To\r\nimplement
this, the expanded panel Id is added to the
url:\r\n\r\n`/app/dashboard/{dashboardID}/{expandedPanelID}_g()_a()`\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Hannah Mudge
<hannah.wright@elastic.co>","sha":"603023124681429ee900ff3a73793ce31a9cad58"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Rachel Shen <rshen@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshen91 rshen91

Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Dashboard Usability Related to the Dashboard Usability initiative regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
8 participants
@IanLee1521 @cqliu1 @tomhe @Heenawter @ThomThomson @elasticmachine @rshen91 @teresaalvarezsoler