Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSVB usability problem typing in fields on IE #14628

Closed
LeeDr opened this issue Oct 26, 2017 · 3 comments
Closed

TSVB usability problem typing in fields on IE #14628

LeeDr opened this issue Oct 26, 2017 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@LeeDr
Copy link
Contributor

LeeDr commented Oct 26, 2017

Kibana version: 6.0.0-rc2

Elasticsearch version: 6.0.0-rc2

Server OS version: Ubuntu

Browser version: Internet Explorer 11

Browser OS version: Windows 10

Original install method (e.g. download page, yum, from source, etc.): tar.gz

Description of the problem including expected versus actual behavior:
On IE, typing in text fields on the Panel Options sub-tab such as the Index Pattern has a major usability problem. If you don't type really slow you lose characters.

Steps to reproduce:

  1. Use IE11 to create a new (or open an existing) TSVB
  2. Go to the Panel Options
  3. As you type in fields, it seems like you're fighting some refresh of the field and some characters make it while others don't. The animated GIF I captured doesn't really show it that well;

elasticsearch

It's also a problem for the Interval, Axis Min, Axis Max and possibly other fields.

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

@LeeDr LeeDr added Feature:TSVB TSVB (Time Series Visual Builder) bug Fixes for quality problems that affect the customer experience labels Oct 26, 2017
@simianhacker
Copy link
Member

This is a bug with React 15 (see: facebook/react#7027)

@mattapperson When you do the refactor we should create our own TextInput component similar to this comment: facebook/react#7027 (comment). I think in order to get this working for now we need to use that work around until we can get updated to React 16.

@tbragin tbragin added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Oct 30, 2017
mattapperson added a commit that referenced this issue Oct 30, 2017
… enter (#14667)

* Don’t use prevent default on IE unless the user pressed enter

* Implament ie fix on number fields too

* share the ie detection lib

* change file names and export types
mattapperson added a commit that referenced this issue Oct 30, 2017
… enter (#14667)

* Don’t use prevent default on IE unless the user pressed enter

* Implament ie fix on number fields too

* share the ie detection lib

* change file names and export types
@LeeDr
Copy link
Contributor Author

LeeDr commented Nov 7, 2017

This does not appear to be fixed on 6.0.0 BC1 build from Nov 6, 2017

In the Index Pattern field I still get the same behavior on IE.

@LeeDr LeeDr reopened this Nov 7, 2017
chrisronline pushed a commit to chrisronline/kibana that referenced this issue Nov 20, 2017
…pressed enter (elastic#14667)

* Don’t use prevent default on IE unless the user pressed enter

* Implament ie fix on number fields too

* share the ie detection lib

* change file names and export types
chrisronline pushed a commit to chrisronline/kibana that referenced this issue Dec 1, 2017
…pressed enter (elastic#14667)

* Don’t use prevent default on IE unless the user pressed enter

* Implament ie fix on number fields too

* share the ie detection lib

* change file names and export types
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Sep 16, 2018
@timroes
Copy link
Contributor

timroes commented Nov 6, 2018

That's lately fixed via #24832 but maybe even before that.

@timroes timroes closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants