[FIX #14628] Don’t use preventDefault() on IE unless the user pressed enter #14667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattapperson
changed the title
|
This also needs to be implemented in |
simianhacker
requested changes
Oct 30, 2017
| const value = Number(_.get(e, 'target.value', defaultValue)); | ||
| if (_.isFunction(handleChange)) { | ||
| return handleChange({ [name]: value }); | ||
| } | ||
| }; | ||
| }; | ||
|
|
||
| function detectIE() { |
There was a problem hiding this comment.
Can this be a library that's shared in both files?
|
@simianhacker updated |
simianhacker
requested changes
Oct 30, 2017
| @@ -1,10 +1,14 @@ | |||
| import _ from 'lodash'; | |||
| import detectIE from './is-ie'; | |||
There was a problem hiding this comment.
can you change this to work like
import { isIE } from './is_ie';
or
import { detectIE } from './detect_id';
We stopped relying on exporting defaults and we also use snake case for all our filenames.
| @@ -0,0 +1,25 @@ | |||
| export default function detectIE() { | |||
There was a problem hiding this comment.
Don't export default... just export the function name.
|
fixed and fixed |
simianhacker
added
Feature:TSVB
simianhacker
approved these changes
Oct 30, 2017
|
LGTM... Make sure and back port to 6.0 and 6.x |
mattapperson
added a commit
that referenced
this pull request
Oct 30, 2017
mattapperson
added a commit
that referenced
this pull request
Oct 30, 2017
|
backported to 6.0 and 6.x (c805c3b) |
|
I reopened the issue #14628 because I'm still seeing the same behavior on the 6.0.0 BC1 build from yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #14628
React 15.x has issues with
event.preventDefault()in ie, while one of those issues is fixed in 15.6.1, the other (facebook/react#7281) is not. This PR is a patch to work around the issue until kibana moves to react 16.xTested in: