Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js apis Maps endpoints getGridTile should return vector tile containing hexegon features when renderAs is "hex" #149068

Closed
jbudz opened this issue Jan 17, 2023 · 2 comments · Fixed by #150768
Closed

Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js apis Maps endpoints getGridTile should return vector tile containing hexegon features when renderAs is "hex" #149068

jbudz opened this issue Jan 17, 2023 · 2 comments · Fixed by #150768
Assignees
@nreese
Labels
failed-es-promotion failed-test A test failure on a tracked branch, potentially flaky-test Feature:Maps impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@jbudz
Copy link
Member

jbudz commented Jan 17, 2023

X-Pack API Integration Tests
x-pack/test/api_integration/apis/maps/get_grid_tile.js

apis Maps endpoints getGridTile should return vector tile containing hexegon features when renderAs is "hex"

Error: expected [ [ { x: 89, y: 710 },
    { x: 67, y: 696 },
    { x: 67, y: 669 },
    { x: 89, y: 657 },
    { x: 112, y: 672 },
    { x: 111, y: 698 },
    { x: 89, y: 710 } ] ] to sort of equal [ [ { x: 111, y: 698 },
    { x: 89, y: 710 },
    { x: 67, y: 696 },
    { x: 67, y: 669 },
    { x: 89, y: 657 },
    { x: 112, y: 672 },
    { x: 111, y: 698 } ] ]
    at Assertion.assert (expect.js:100:11)
    at Assertion.eql (expect.js:244:8)
    at Context.<anonymous> (get_grid_tile.js:152:45)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (wrap_function.js:73:16) {
  actual: '[\n' +
    '  [\n' +
    '    {\n' +
    '      "x": 89\n' +
    '      "y": 710\n' +
    '    }\n' +
    '    {\n' +
    '      "x": 67\n' +
    '      "y": 696\n' +
    '    }\n' +
    '    {\n' +
    '      "x": 67\n' +
    '      "y": 669\n' +
    '    }\n' +
    '    {\n' +
    '      "x": 89\n' +
    '      "y": 657\n' +
    '    }\n' +
    '    {\n' +
    '      "x": 112\n' +
    '      "y": 672\n' +
    '    }\n' +
    '    {\n' +
    '      "x": 111\n' +
    '      "y": 698\n' +
    '    }\n' +
    '    {\n' +
    '      "x": 89\n' +
    '      "y": 710\n' +
    '    }\n' +
    '  ]\n' +
    ']',
  expected: '[\n' +
    '  [\n' +
    '    {\n' +
    '      "x": 111\n' +
    '      "y": 698\n' +
    '    }\n' +
    '    {\n' +
    '      "x": 89\n' +
    '      "y": 710\n' +
    '    }\n' +
    '    {\n' +
    '      "x": 67\n' +
    '      "y": 696\n' +
    '    }\n' +
    '    {\n' +
    '      "x": 67\n' +
    '      "y": 669\n' +
    '    }\n' +
    '    {\n' +
    '      "x": 89\n' +
    '      "y": 657\n' +
    '    }\n' +
    '    {\n' +
    '      "x": 112\n' +
    '      "y": 672\n' +
    '    }\n' +
    '    {\n' +
    '      "x": 111\n' +
    '      "y": 698\n' +
    '    }\n' +
    '  ]\n' +
    ']',
  showDiff: true
}
@jbudz jbudz added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas failed-es-promotion Feature:Maps labels Jan 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

jbudz added a commit that referenced this issue Jan 17, 2023
@jbudz
skip suite failing es promotion (#149068)
9d571d9
@jbudz
Copy link
Member Author

jbudz commented Jan 17, 2023

Skipped

main: 9d571d9

@nreese nreese added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. failed-test A test failure on a tracked branch, potentially flaky-test labels Jan 26, 2023
@nreese nreese mentioned this issue Feb 9, 2023
Merged
@nreese nreese self-assigned this Feb 9, 2023
nreese added a commit that referenced this issue Feb 9, 2023
@nreese
fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/…
d6a4ebf 
…api_integration/apis/maps/get_grid_tile.js (#150768)

Fixes #149068

Order of the vertices changed as side effect of
elastic/elasticsearch#92883. PR updates expects
clause for new order
kibanamachine pushed a commit that referenced this issue Feb 9, 2023
@nreese
fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/…
8caad40 
…api_integration/apis/maps/get_grid_tile.js (#150768)

Fixes #149068

Order of the vertices changed as side effect of
elastic/elasticsearch#92883. PR updates expects
clause for new order

(cherry picked from commit d6a4ebf)
kibanamachine referenced this issue Feb 9, 2023
@kibanamachine @nreese
[8.7] fixes Failing ES Promotion: X-Pack API Integration Tests x-pack…
c36b539 
…/test/api_integration/apis/maps/get_grid_tile.js (#150768) (#150794)

# Backport

This will backport the following commits from `main` to `8.7`:
- [fixes Failing ES Promotion: X-Pack API Integration Tests
x-pack/test/api_integration/apis/maps/get_grid_tile.js
(#150768)](#150768)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-02-09T21:35:28Z","message":"fixes
Failing ES Promotion: X-Pack API Integration Tests
x-pack/test/api_integration/apis/maps/get_grid_tile.js
(#150768)\n\nFixes
https://github.com/elastic/kibana/issues/149068\r\n\r\nOrder of the
vertices changed as side effect
of\r\nhttps://github.com/elastic/elasticsearch/pull/92883. PR updates
expects\r\nclause for new
order","sha":"d6a4ebf46d9af18618cfed16666921b58db1e400","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","auto-backport","Feature:Maps","v8.7.0","v8.8.0"],"number":150768,"url":"https://github.com/elastic/kibana/pull/150768","mergeCommit":{"message":"fixes
Failing ES Promotion: X-Pack API Integration Tests
x-pack/test/api_integration/apis/maps/get_grid_tile.js
(#150768)\n\nFixes
https://github.com/elastic/kibana/issues/149068\r\n\r\nOrder of the
vertices changed as side effect
of\r\nhttps://github.com/elastic/elasticsearch/pull/92883. PR updates
expects\r\nclause for new
order","sha":"d6a4ebf46d9af18618cfed16666921b58db1e400"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150768","number":150768,"mergeCommit":{"message":"fixes
Failing ES Promotion: X-Pack API Integration Tests
x-pack/test/api_integration/apis/maps/get_grid_tile.js
(#150768)\n\nFixes
https://github.com/elastic/kibana/issues/149068\r\n\r\nOrder of the
vertices changed as side effect
of\r\nhttps://github.com/elastic/elasticsearch/pull/92883. PR updates
expects\r\nclause for new
order","sha":"d6a4ebf46d9af18618cfed16666921b58db1e400"}}]}] BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
failed-es-promotion failed-test A test failure on a tracked branch, potentially flaky-test Feature:Maps impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
4 participants
@nreese @jbudz @elasticmachine @kibanamachine