Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js #150768

Merged
merged 1 commit into from
Feb 9, 2023
Merged

fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js #150768

merged 1 commit into from
Feb 9, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Feb 9, 2023

Fixes #149068

Order of the vertices changed as side effect of elastic/elasticsearch#92883. PR updates expects clause for new order

@nreese nreese marked this pull request as ready for review February 9, 2023 19:09
@nreese nreese requested a review from a team as a code owner February 9, 2023 19:09
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.7.0 v8.8.0 labels Feb 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese requested a review from nickpeihl February 9, 2023 19:10
nickpeihl
nickpeihl approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if ci passes

code review

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit d6a4ebf into elastic:main Feb 9, 2023
kibanamachine pushed a commit that referenced this pull request Feb 9, 2023
@nreese
fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/…
8caad40 
…api_integration/apis/maps/get_grid_tile.js (#150768)

Fixes #149068

Order of the vertices changed as side effect of
elastic/elasticsearch#92883. PR updates expects
clause for new order

(cherry picked from commit d6a4ebf)
@kibanamachine kibanamachine mentioned this pull request Feb 9, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Feb 9, 2023
@kibanamachine @nreese
[8.7] fixes Failing ES Promotion: X-Pack API Integration Tests x-pack…
c36b539 
…/test/api_integration/apis/maps/get_grid_tile.js (#150768) (#150794)

# Backport

This will backport the following commits from `main` to `8.7`:
- [fixes Failing ES Promotion: X-Pack API Integration Tests
x-pack/test/api_integration/apis/maps/get_grid_tile.js
(#150768)](#150768)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-02-09T21:35:28Z","message":"fixes
Failing ES Promotion: X-Pack API Integration Tests
x-pack/test/api_integration/apis/maps/get_grid_tile.js
(#150768)\n\nFixes
#149068 of the
vertices changed as side effect
of\r\nhttps://github.com/elastic/elasticsearch/pull/92883. PR updates
expects\r\nclause for new
order","sha":"d6a4ebf46d9af18618cfed16666921b58db1e400","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","auto-backport","Feature:Maps","v8.7.0","v8.8.0"],"number":150768,"url":"#150768
Failing ES Promotion: X-Pack API Integration Tests
x-pack/test/api_integration/apis/maps/get_grid_tile.js
(#150768)\n\nFixes
#149068 of the
vertices changed as side effect
of\r\nhttps://github.com/elastic/elasticsearch/pull/92883. PR updates
expects\r\nclause for new
order","sha":"d6a4ebf46d9af18618cfed16666921b58db1e400"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#150768
Failing ES Promotion: X-Pack API Integration Tests
x-pack/test/api_integration/apis/maps/get_grid_tile.js
(#150768)\n\nFixes
#149068 of the
vertices changed as side effect
of\r\nhttps://github.com/elastic/elasticsearch/pull/92883. PR updates
expects\r\nclause for new
order","sha":"d6a4ebf46d9af18618cfed16666921b58db1e400"}}]}] BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 10, 2023
@jloleysens
Merge branch 'main' into compatible-schema-change-check
a9b2e06 
* main: (115 commits)
  [Custom branding] Add custom logo to space selector (elastic#150284)
  [api-docs] 2023-02-10 Daily api_docs build (elastic#150831)
  [ci] build next docs in PRs when relevant files change (elastic#149991)
  [codeowners] allow overrides to take higher precedence (elastic#150821)
  [docs] Remove kibDevDocsOpsPluginDiscovery (elastic#150788)
  [Fleet] Fix max 20 installed integrations returned from Fleet API (elastic#150780)
  [maps] fix Changing resolutions on Heat map layer throws error in console (elastic#150761)
  fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js (elastic#150768)
  [Synthetics] adjust overview scrolling e2e (elastic#150774)
  [Security Solution] Fixes bulk close alerts from exception flyout type bug (elastic#150765)
  Upgrade EUI to v74.1.0 (elastic#150235)
  [skip ci] Fix labeling for Infrastructure UI (elastic#150571)
  [Enterprise Search] Move pipelines modal to flyout (elastic#150727)
  [Security Solution] fix flaky endpoint tests (elastic#150652)
  Fixes the space selector page layout  (elastic#150503)
  [Dashboard] [Navigation] Fix mount point bug (elastic#150507)
  [Infrastructure UI] Track host cloud provider on table entry click (elastic#150685)
  [Dashboard Usability] Moves scrollbar to panel section (elastic#145628)
  [Maps] fixes Kibana maps shows MVT borders if the geometry border style is greater than 1 (elastic#150497)
  [Cloud Posture][Dashboard] dashboard re-design enhancements (elastic#150394)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Maps release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
5 participants
@nreese @elasticmachine @kibana-ci @kibanamachine @nickpeihl