[Infrastructure UI] Track host cloud provider on table entry click #150685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyghiani
added
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
tonyghiani
changed the title
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 9, 2023
…lastic#150685) ## 📓 Summary Closes elastic#150681 The tracked event when clicking an entry from the Hosts table was not applying correctly the default `unknow` string for the `cloud_provider` parameter. Now it defaults to it in case the value is not passed or is null. ## 🧪 Testing - Navigate to the Hosts view - Open the console dev tools - Click on a host name from the table and navigate to the host detail. - Verify the following error does not appear in the log ``` Uncaught Error: Failed to validate payload coming from "Event Type 'Host Entry Clicked'": [cloud_provider]: {"expected":"string","actual":"object","value":null} ``` Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> (cherry picked from commit 26eddec)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 9, 2023
…ick (#150685) (#150760) # Backport This will backport the following commits from `main` to `8.7`: - [[Infrastructure UI] Track host cloud provider on table entry click (#150685)](#150685) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2023-02-09T18:19:10Z","message":"[Infrastructure UI] Track host cloud provider on table entry click (#150685)\n\n## 📓 Summary\r\n\r\nCloses #150681 \r\n\r\nThe tracked event when clicking an entry from the Hosts table was not\r\napplying correctly the default `unknow` string for the `cloud_provider`\r\nparameter.\r\nNow it defaults to it in case the value is not passed or is null.\r\n\r\n## 🧪 Testing\r\n- Navigate to the Hosts view\r\n- Open the console dev tools\r\n- Click on a host name from the table and navigate to the host detail.\r\n- Verify the following error does not appear in the log\r\n```\r\nUncaught Error: Failed to validate payload coming from \"Event Type 'Host Entry Clicked'\":\r\n[cloud_provider]: {\"expected\":\"string\",\"actual\":\"object\",\"value\":null}\r\n```\r\n\r\nCo-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>","sha":"26eddec70844ffb65e5d3521a7adb52e643c4534","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra Monitoring UI","release_note:skip","v8.7.0","v8.8.0"],"number":150685,"url":"#150685 UI] Track host cloud provider on table entry click (#150685)\n\n## 📓 Summary\r\n\r\nCloses #150681 \r\n\r\nThe tracked event when clicking an entry from the Hosts table was not\r\napplying correctly the default `unknow` string for the `cloud_provider`\r\nparameter.\r\nNow it defaults to it in case the value is not passed or is null.\r\n\r\n## 🧪 Testing\r\n- Navigate to the Hosts view\r\n- Open the console dev tools\r\n- Click on a host name from the table and navigate to the host detail.\r\n- Verify the following error does not appear in the log\r\n```\r\nUncaught Error: Failed to validate payload coming from \"Event Type 'Host Entry Clicked'\":\r\n[cloud_provider]: {\"expected\":\"string\",\"actual\":\"object\",\"value\":null}\r\n```\r\n\r\nCo-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>","sha":"26eddec70844ffb65e5d3521a7adb52e643c4534"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#150685 UI] Track host cloud provider on table entry click (#150685)\n\n## 📓 Summary\r\n\r\nCloses #150681 \r\n\r\nThe tracked event when clicking an entry from the Hosts table was not\r\napplying correctly the default `unknow` string for the `cloud_provider`\r\nparameter.\r\nNow it defaults to it in case the value is not passed or is null.\r\n\r\n## 🧪 Testing\r\n- Navigate to the Hosts view\r\n- Open the console dev tools\r\n- Click on a host name from the table and navigate to the host detail.\r\n- Verify the following error does not appear in the log\r\n```\r\nUncaught Error: Failed to validate payload coming from \"Event Type 'Host Entry Clicked'\":\r\n[cloud_provider]: {\"expected\":\"string\",\"actual\":\"object\",\"value\":null}\r\n```\r\n\r\nCo-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>","sha":"26eddec70844ffb65e5d3521a7adb52e643c4534"}}]}] BACKPORT--> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 10, 2023
* main: (115 commits) [Custom branding] Add custom logo to space selector (elastic#150284) [api-docs] 2023-02-10 Daily api_docs build (elastic#150831) [ci] build next docs in PRs when relevant files change (elastic#149991) [codeowners] allow overrides to take higher precedence (elastic#150821) [docs] Remove kibDevDocsOpsPluginDiscovery (elastic#150788) [Fleet] Fix max 20 installed integrations returned from Fleet API (elastic#150780) [maps] fix Changing resolutions on Heat map layer throws error in console (elastic#150761) fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js (elastic#150768) [Synthetics] adjust overview scrolling e2e (elastic#150774) [Security Solution] Fixes bulk close alerts from exception flyout type bug (elastic#150765) Upgrade EUI to v74.1.0 (elastic#150235) [skip ci] Fix labeling for Infrastructure UI (elastic#150571) [Enterprise Search] Move pipelines modal to flyout (elastic#150727) [Security Solution] fix flaky endpoint tests (elastic#150652) Fixes the space selector page layout (elastic#150503) [Dashboard] [Navigation] Fix mount point bug (elastic#150507) [Infrastructure UI] Track host cloud provider on table entry click (elastic#150685) [Dashboard Usability] Moves scrollbar to panel section (elastic#145628) [Maps] fixes Kibana maps shows MVT borders if the geometry border style is greater than 1 (elastic#150497) [Cloud Posture][Dashboard] dashboard re-design enhancements (elastic#150394) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 Summary
Closes #150681
The tracked event when clicking an entry from the Hosts table was not applying correctly the default
unknowstring for thecloud_providerparameter.Now it defaults to it in case the value is not passed or is null.
🧪 Testing