-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infrastructure UI] Hosts clicked event not tracking default cloud provider #150681
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:ObsHosts
Hosts feature within Observability
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Comments
tonyghiani
added
bug
Fixes for quality problems that affect the customer experience
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Feature:ObsHosts
Hosts feature within Observability
labels
Feb 9, 2023
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
tonyghiani
added a commit
that referenced
this issue
Feb 9, 2023
…150685) ## 📓 Summary Closes #150681 The tracked event when clicking an entry from the Hosts table was not applying correctly the default `unknow` string for the `cloud_provider` parameter. Now it defaults to it in case the value is not passed or is null. ## 🧪 Testing - Navigate to the Hosts view - Open the console dev tools - Click on a host name from the table and navigate to the host detail. - Verify the following error does not appear in the log ``` Uncaught Error: Failed to validate payload coming from "Event Type 'Host Entry Clicked'": [cloud_provider]: {"expected":"string","actual":"object","value":null} ``` Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Feb 9, 2023
…lastic#150685) ## 📓 Summary Closes elastic#150681 The tracked event when clicking an entry from the Hosts table was not applying correctly the default `unknow` string for the `cloud_provider` parameter. Now it defaults to it in case the value is not passed or is null. ## 🧪 Testing - Navigate to the Hosts view - Open the console dev tools - Click on a host name from the table and navigate to the host detail. - Verify the following error does not appear in the log ``` Uncaught Error: Failed to validate payload coming from "Event Type 'Host Entry Clicked'": [cloud_provider]: {"expected":"string","actual":"object","value":null} ``` Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> (cherry picked from commit 26eddec)
kibanamachine
added a commit
that referenced
this issue
Feb 9, 2023
…ick (#150685) (#150760) # Backport This will backport the following commits from `main` to `8.7`: - [[Infrastructure UI] Track host cloud provider on table entry click (#150685)](#150685) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2023-02-09T18:19:10Z","message":"[Infrastructure UI] Track host cloud provider on table entry click (#150685)\n\n## 📓 Summary\r\n\r\nCloses #150681 \r\n\r\nThe tracked event when clicking an entry from the Hosts table was not\r\napplying correctly the default `unknow` string for the `cloud_provider`\r\nparameter.\r\nNow it defaults to it in case the value is not passed or is null.\r\n\r\n## 🧪 Testing\r\n- Navigate to the Hosts view\r\n- Open the console dev tools\r\n- Click on a host name from the table and navigate to the host detail.\r\n- Verify the following error does not appear in the log\r\n```\r\nUncaught Error: Failed to validate payload coming from \"Event Type 'Host Entry Clicked'\":\r\n[cloud_provider]: {\"expected\":\"string\",\"actual\":\"object\",\"value\":null}\r\n```\r\n\r\nCo-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>","sha":"26eddec70844ffb65e5d3521a7adb52e643c4534","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra Monitoring UI","release_note:skip","v8.7.0","v8.8.0"],"number":150685,"url":"https://github.com/elastic/kibana/pull/150685","mergeCommit":{"message":"[Infrastructure UI] Track host cloud provider on table entry click (#150685)\n\n## 📓 Summary\r\n\r\nCloses #150681 \r\n\r\nThe tracked event when clicking an entry from the Hosts table was not\r\napplying correctly the default `unknow` string for the `cloud_provider`\r\nparameter.\r\nNow it defaults to it in case the value is not passed or is null.\r\n\r\n## 🧪 Testing\r\n- Navigate to the Hosts view\r\n- Open the console dev tools\r\n- Click on a host name from the table and navigate to the host detail.\r\n- Verify the following error does not appear in the log\r\n```\r\nUncaught Error: Failed to validate payload coming from \"Event Type 'Host Entry Clicked'\":\r\n[cloud_provider]: {\"expected\":\"string\",\"actual\":\"object\",\"value\":null}\r\n```\r\n\r\nCo-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>","sha":"26eddec70844ffb65e5d3521a7adb52e643c4534"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150685","number":150685,"mergeCommit":{"message":"[Infrastructure UI] Track host cloud provider on table entry click (#150685)\n\n## 📓 Summary\r\n\r\nCloses #150681 \r\n\r\nThe tracked event when clicking an entry from the Hosts table was not\r\napplying correctly the default `unknow` string for the `cloud_provider`\r\nparameter.\r\nNow it defaults to it in case the value is not passed or is null.\r\n\r\n## 🧪 Testing\r\n- Navigate to the Hosts view\r\n- Open the console dev tools\r\n- Click on a host name from the table and navigate to the host detail.\r\n- Verify the following error does not appear in the log\r\n```\r\nUncaught Error: Failed to validate payload coming from \"Event Type 'Host Entry Clicked'\":\r\n[cloud_provider]: {\"expected\":\"string\",\"actual\":\"object\",\"value\":null}\r\n```\r\n\r\nCo-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>","sha":"26eddec70844ffb65e5d3521a7adb52e643c4534"}}]}] BACKPORT--> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:ObsHosts
Hosts feature within Observability
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
📓 Problem description
When clicking on a host from the hosts' table in the hosts' view, we should track
unknown
as the default value if the cloud provider is not specified. Currently, it tracks thenull
value.✔️ Acceptance criteria
cloudProvider: "unknown"
on the Host Entry Clicked event when the cloud provider is not specified for a host.The text was updated successfully, but these errors were encountered: